[PR #2268] [MERGED] texture_cache: Make sure left-overlapped mips get marked for rebind. #2611

Closed
opened 2026-02-27 22:00:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2268
Author: @squidbus
Created: 1/29/2025
Status: Merged
Merged: 2/1/2025
Merged by: @squidbus

Base: mainHead: mip-fix-2


📝 Commits (1)

  • c7168ae texture_cache: Make sure left-overlapped mips get marked for rebind.

📊 Changes

1 file changed (+13 additions, -13 deletions)

View changed files

📝 src/video_core/texture_cache/texture_cache.cpp (+13 -13)

📄 Description

Make sure a left-overlapped mip level gets marked for rebind, even if the replacement image has not been allocated yet.

Fixes some cases where, instead of rendering to the mip level, it will render to the base image since it wasn't rebound.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2268 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/29/2025 **Status:** ✅ Merged **Merged:** 2/1/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `mip-fix-2` --- ### 📝 Commits (1) - [`c7168ae`](https://github.com/shadps4-emu/shadPS4/commit/c7168aee6bfd361347296593f2baf6d82cd108e4) texture_cache: Make sure left-overlapped mips get marked for rebind. ### 📊 Changes **1 file changed** (+13 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/texture_cache/texture_cache.cpp` (+13 -13) </details> ### 📄 Description Make sure a left-overlapped mip level gets marked for rebind, even if the replacement image has not been allocated yet. Fixes some cases where, instead of rendering to the mip level, it will render to the base image since it wasn't rebound. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:00:35 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2611
No description provided.