[PR #2497] [CLOSED] Adding stop function to help with check update while running a game #2784

New issue

Closed

opened 2026-02-27 22:01:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2497
Author: @diegolix29
Created: 2/21/2025
Status: ❌ Closed

Base: main ← Head: Auto-update-QoL

📝 Commits (7)

8136975 Adding stop button function to help with check update while running a game.
3d8e3b0 clang
c1630f7 last clang
78d5d26 fixes and suggestions
f952dcf clean up pr
7fb9521 fixing flags
78ef595 adding initializer to quit events and show messaage no game is currently running when clicking stop button and no game ir running.

📊 Changes

9 files changed (+185 additions, -10 deletions)

View changed files

📝 src/emulator.cpp (+14 -0)
📝 src/emulator.h (+11 -0)
📝 src/qt_gui/check_update.cpp (+11 -2)
📝 src/qt_gui/check_update.h (+5 -1)
📝 src/qt_gui/main_window.cpp (+46 -2)
📝 src/qt_gui/main_window.h (+7 -1)
📝 src/qt_gui/settings_dialog.cpp (+8 -3)
📝 src/sdl_window.cpp (+82 -1)
📝 src/sdl_window.h (+1 -0)

📄 Description

this pr helps with the lock error while updating if u running a game

https://github.com/user-attachments/assets/97ae5abe-1eab-49a7-ad4a-7130b224d16d

now if u update while running a game it shows a box with a warning and then stop the game to let the update installation continue without issues

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2497 **Author:** [@diegolix29](https://github.com/diegolix29) **Created:** 2/21/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `Auto-update-QoL` --- ### 📝 Commits (7) - [`8136975`](https://github.com/shadps4-emu/shadPS4/commit/81369755e4ee9f29e1b5b025afb6fb2303355906) Adding stop button function to help with check update while running a game. - [`3d8e3b0`](https://github.com/shadps4-emu/shadPS4/commit/3d8e3b0429b1e3563e73c499cd24ae801262051a) clang - [`c1630f7`](https://github.com/shadps4-emu/shadPS4/commit/c1630f7ebdc98baa9a5f3eca1393cc87f28ccd93) last clang - [`78d5d26`](https://github.com/shadps4-emu/shadPS4/commit/78d5d265bbbb785284207261612b2bae41785621) fixes and suggestions - [`f952dcf`](https://github.com/shadps4-emu/shadPS4/commit/f952dcf035469c4ce178ca2af832021b8a50e5ec) clean up pr - [`7fb9521`](https://github.com/shadps4-emu/shadPS4/commit/7fb95216cf18033f90d205c688cdbd73696fb8dc) fixing flags - [`78ef595`](https://github.com/shadps4-emu/shadPS4/commit/78ef595db3e090cd86b735098ddb94dda764574d) adding initializer to quit events and show messaage no game is currently running when clicking stop button and no game ir running. ### 📊 Changes **9 files changed** (+185 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/emulator.cpp` (+14 -0) 📝 `src/emulator.h` (+11 -0) 📝 `src/qt_gui/check_update.cpp` (+11 -2) 📝 `src/qt_gui/check_update.h` (+5 -1) 📝 `src/qt_gui/main_window.cpp` (+46 -2) 📝 `src/qt_gui/main_window.h` (+7 -1) 📝 `src/qt_gui/settings_dialog.cpp` (+8 -3) 📝 `src/sdl_window.cpp` (+82 -1) 📝 `src/sdl_window.h` (+1 -0) </details> ### 📄 Description this pr helps with the lock error while updating if u running a game ![image](https://github.com/user-attachments/assets/9acee269-80d2-4bcf-8009-8bdae3439f0a) https://github.com/user-attachments/assets/97ae5abe-1eab-49a7-ad4a-7130b224d16d now if u update while running a game it shows a box with a warning and then stop the game to let the update installation continue without issues ![image](https://github.com/user-attachments/assets/da70ee8c-6e1e-4fb8-b2b6-a2801e4ef4bc) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>