[PR #2118] [MERGED] shader_recompiler: Fix some image view type issues. #2497

New issue

Closed

opened 2026-02-27 22:00:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2118
Author: @squidbus
Created: 1/10/2025
Status: ✅ Merged
Merged: 1/10/2025
Merged by: @squidbus

Base: main ← Head: image-type-2

📝 Commits (1)

c57b5a3 shader_recompiler: Fix some image view type issues.

📊 Changes

7 files changed (+30 additions, -22 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_image.cpp (+2 -3)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+2 -2)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.h (+1 -1)
📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+11 -9)
📝 src/shader_recompiler/specialization.h (+1 -1)
📝 src/video_core/amdgpu/resource.h (+12 -5)
📝 src/video_core/texture_cache/image_view.cpp (+1 -1)

📄 Description

Few small fix-ups for new image type handling:

Clarify naming by changing image bound type to view type.
Fix cube non-array potentially being remapped to 2D texture via 2D array check.
Fix image instruction parameter resolution considering base type instead of view type. Have confirmed now this is the correct way to handle it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2118 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/10/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `image-type-2` --- ### 📝 Commits (1) - [`c57b5a3`](https://github.com/shadps4-emu/shadPS4/commit/c57b5a36a753559a949e77f8fe31ee0d495cc1ea) shader_recompiler: Fix some image view type issues. ### 📊 Changes **7 files changed** (+30 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_image.cpp` (+2 -3) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+2 -2) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.h` (+1 -1) 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+11 -9) 📝 `src/shader_recompiler/specialization.h` (+1 -1) 📝 `src/video_core/amdgpu/resource.h` (+12 -5) 📝 `src/video_core/texture_cache/image_view.cpp` (+1 -1) </details> ### 📄 Description Few small fix-ups for new image type handling: * Clarify naming by changing image `bound type` to `view type`. * Fix cube non-array potentially being remapped to 2D texture via 2D array check. * Fix image instruction parameter resolution considering base type instead of view type. Have confirmed now this is the correct way to handle it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>