[PR #2490] [MERGED] QT: Fix search in Grid mode #2776

New issue

Closed

opened 2026-02-27 22:01:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2490
Author: @DanielSvoboda
Created: 2/21/2025
Status: ✅ Merged
Merged: 2/21/2025
Merged by: @georgemoralis

Base: main ← Head: main

📝 Commits (4)

a6e6067 QT: Fix search in Grid mode
a884629 Fix performance?
8275878 Fix performance List
313dbd7 +fix

📊 Changes

3 files changed (+17 additions, -0 deletions)

View changed files

📝 src/qt_gui/game_info.cpp (+3 -0)
📝 src/qt_gui/game_info.h (+1 -0)
📝 src/qt_gui/main_window.cpp (+13 -0)

📄 Description

The search works correctly in list mode. However, when using search in grid mode, the results are correct, but the itemID values in gui_context_menus.h were not accurate.

What was happening? After searching for a game, it would show up correctly in the list. However, when trying to open or interact with it in any way (such as using cheats/patches, opening or deleting the folder, or in any other context), it was using the ID from the table without the search filter.

Watch the video, it's easier to understand:

https://github.com/user-attachments/assets/1c494e51-f9ad-4ed8-8c8f-1fd7a0ab06b3

This PR fixes this issue, and also when switching from Grid to List or vice versa the search field is reset, as this would cause problems.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2490 **Author:** [@DanielSvoboda](https://github.com/DanielSvoboda) **Created:** 2/21/2025 **Status:** ✅ Merged **Merged:** 2/21/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`a6e6067`](https://github.com/shadps4-emu/shadPS4/commit/a6e606714397b076b0d621181a7b16e317fe629d) QT: Fix search in Grid mode - [`a884629`](https://github.com/shadps4-emu/shadPS4/commit/a884629923bdba81801500b65186182b5895e06c) Fix performance? - [`8275878`](https://github.com/shadps4-emu/shadPS4/commit/8275878cbae6c04c4ebb4d9fd34e7e4ed33c8f0d) Fix performance List - [`313dbd7`](https://github.com/shadps4-emu/shadPS4/commit/313dbd7536049acd76dfe4f3d2917c98c4d46f45) +fix ### 📊 Changes **3 files changed** (+17 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/game_info.cpp` (+3 -0) 📝 `src/qt_gui/game_info.h` (+1 -0) 📝 `src/qt_gui/main_window.cpp` (+13 -0) </details> ### 📄 Description The search works correctly in list mode. However, when using search in grid mode, the results are correct, but the itemID values in gui_context_menus.h were not accurate. What was happening? After searching for a game, it would show up correctly in the list. However, when trying to open or interact with it in any way (such as using cheats/patches, opening or deleting the folder, or in any other context), it was using the ID from the table without the search filter. Watch the video, it's easier to understand: https://github.com/user-attachments/assets/1c494e51-f9ad-4ed8-8c8f-1fd7a0ab06b3 This PR fixes this issue, and also when switching from Grid to List or vice versa the search field is reset, as this would cause problems. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>