[PR #2097] [MERGED] shader_recompiler: Ignore exec mask for scalar instructions. #2490

Closed
opened 2026-02-27 22:00:06 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2097
Author: @squidbus
Created: 1/8/2025
Status: Merged
Merged: 1/8/2025
Merged by: @georgemoralis

Base: mainHead: fix-exec


📝 Commits (1)

  • f6452c6 shader_recompiler: Ignore exec mask for scalar instructions.

📊 Changes

1 file changed (+17 additions, -5 deletions)

View changed files

📝 src/shader_recompiler/frontend/control_flow_graph.cpp (+17 -5)

📄 Description

Looking at Mesa and other AMD ISA specs, it seems that the EXEC mask does not affect scalar or control flow instructions. This PR adds those to the EXEC ignore checks, as well as the rest of the vector read/write lane instructions since those are also documented to ignore it.

Fixes device loss entering first level in CUSA28193, improves graphics in CUSA05637, probably helps others as well.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2097 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 1/8/2025 **Status:** ✅ Merged **Merged:** 1/8/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-exec` --- ### 📝 Commits (1) - [`f6452c6`](https://github.com/shadps4-emu/shadPS4/commit/f6452c628b718a3fc2ee68612b7490ddd55b79b4) shader_recompiler: Ignore exec mask for scalar instructions. ### 📊 Changes **1 file changed** (+17 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/frontend/control_flow_graph.cpp` (+17 -5) </details> ### 📄 Description Looking at Mesa and other AMD ISA specs, it seems that the EXEC mask does not affect scalar or control flow instructions. This PR adds those to the EXEC ignore checks, as well as the rest of the vector read/write lane instructions since those are also documented to ignore it. Fixes device loss entering first level in CUSA28193, improves graphics in CUSA05637, probably helps others as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:00:06 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2490
No description provided.