[PR #2456] [MERGED] avplayer: implemented AddSourceEx, SetAvSyncMode, Pause and Resume #2749

New issue

Closed

opened 2026-02-27 22:01:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:01:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2456
Author: @roamic
Created: 2/16/2025
Status: ✅ Merged
Merged: 9/20/2025
Merged by: @georgemoralis

Base: main ← Head: avplayer-improvements

📝 Commits (10+)

adcb04f avplayer: code improvements
513193e avplayer: implemented pause/resume
6a63fab avplayer: implemented sync modes
9186798 avplayer: issue warning on loopback
567aaea avplayer: sync on video ts in default mode when audio ts is not available
3fc4ec9 avplayer: removed waits for the frame in Get*Data, replaced cv with sleep
94236f9 avplayer: removed all waits from GetVideoData
c366c70 avplayer: fix warning propagation + small fixes
b40fbed Using texture memory for video frames, dropped video frame cache, syncing audio to video
e2e607e do not sync to audio when audio is not enabled

📊 Changes

12 files changed (+448 additions, -369 deletions)

View changed files

📝 src/core/libraries/avplayer/avplayer.cpp (+56 -86)
📝 src/core/libraries/avplayer/avplayer.h (+82 -82)
📝 src/core/libraries/avplayer/avplayer_common.cpp (+7 -7)
📝 src/core/libraries/avplayer/avplayer_common.h (+6 -1)
📝 src/core/libraries/avplayer/avplayer_file_streamer.cpp (+2 -2)
📝 src/core/libraries/avplayer/avplayer_file_streamer.h (+2 -2)
📝 src/core/libraries/avplayer/avplayer_impl.cpp (+44 -14)
📝 src/core/libraries/avplayer/avplayer_impl.h (+13 -10)
📝 src/core/libraries/avplayer/avplayer_source.cpp (+99 -98)
📝 src/core/libraries/avplayer/avplayer_source.h (+56 -31)
📝 src/core/libraries/avplayer/avplayer_state.cpp (+63 -23)
📝 src/core/libraries/avplayer/avplayer_state.h (+18 -13)

📄 Description

Implemented the local part of the sceAvPlayerAddSourceEx
Implemented sceAvPlayerPause and sceAvPlayerResume
Implemented sceAvPlayerSetAvSyncMode
Properly issuing a warning each time the source is looping.
Renamed some variables and types to match the coding style of the code base.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2456 **Author:** [@roamic](https://github.com/roamic) **Created:** 2/16/2025 **Status:** ✅ Merged **Merged:** 9/20/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `avplayer-improvements` --- ### 📝 Commits (10+) - [`adcb04f`](https://github.com/shadps4-emu/shadPS4/commit/adcb04f0671cb7fecd970f03b21b141001ca7144) avplayer: code improvements - [`513193e`](https://github.com/shadps4-emu/shadPS4/commit/513193e74896db306bd1cedbb1434a02fbb81813) avplayer: implemented pause/resume - [`6a63fab`](https://github.com/shadps4-emu/shadPS4/commit/6a63fab9be8d69746e6effc2b00284263eebab7f) avplayer: implemented sync modes - [`9186798`](https://github.com/shadps4-emu/shadPS4/commit/9186798cd3cbcc9f38de6e4518099829042a3025) avplayer: issue warning on loopback - [`567aaea`](https://github.com/shadps4-emu/shadPS4/commit/567aaea9a6b7ee7e4991c5be06ee512754f30c9a) avplayer: sync on video ts in default mode when audio ts is not available - [`3fc4ec9`](https://github.com/shadps4-emu/shadPS4/commit/3fc4ec9138b8d48969f8bc0017ac7c6b407267ba) avplayer: removed waits for the frame in Get*Data, replaced cv with sleep - [`94236f9`](https://github.com/shadps4-emu/shadPS4/commit/94236f9bd6d3b68149b4706eb6a8cc3146584b64) avplayer: removed all waits from GetVideoData - [`c366c70`](https://github.com/shadps4-emu/shadPS4/commit/c366c70f13a03833e0eea9556141d84769bd84d5) avplayer: fix warning propagation + small fixes - [`b40fbed`](https://github.com/shadps4-emu/shadPS4/commit/b40fbed9b59536d90ab43a5f1528d3edd3b96a1b) Using texture memory for video frames, dropped video frame cache, syncing audio to video - [`e2e607e`](https://github.com/shadps4-emu/shadPS4/commit/e2e607e626384ccd3b38bd77d04542335554ecad) do not sync to audio when audio is not enabled ### 📊 Changes **12 files changed** (+448 additions, -369 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/avplayer/avplayer.cpp` (+56 -86) 📝 `src/core/libraries/avplayer/avplayer.h` (+82 -82) 📝 `src/core/libraries/avplayer/avplayer_common.cpp` (+7 -7) 📝 `src/core/libraries/avplayer/avplayer_common.h` (+6 -1) 📝 `src/core/libraries/avplayer/avplayer_file_streamer.cpp` (+2 -2) 📝 `src/core/libraries/avplayer/avplayer_file_streamer.h` (+2 -2) 📝 `src/core/libraries/avplayer/avplayer_impl.cpp` (+44 -14) 📝 `src/core/libraries/avplayer/avplayer_impl.h` (+13 -10) 📝 `src/core/libraries/avplayer/avplayer_source.cpp` (+99 -98) 📝 `src/core/libraries/avplayer/avplayer_source.h` (+56 -31) 📝 `src/core/libraries/avplayer/avplayer_state.cpp` (+63 -23) 📝 `src/core/libraries/avplayer/avplayer_state.h` (+18 -13) </details> ### 📄 Description * Implemented the local part of the `sceAvPlayerAddSourceEx` * Implemented `sceAvPlayerPause` and `sceAvPlayerResume` * Implemented `sceAvPlayerSetAvSyncMode` * Properly issuing a warning each time the source is looping. * Renamed some variables and types to match the coding style of the code base. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>