[PR #2346] [MERGED] Fix issues with input detection due to overloaded ring buffer and fix buffer size being incorrect #2667

New issue

Closed

opened 2026-02-27 22:00:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2346
Author: @kalaposfos13
Created: 2/4/2025
Status: ✅ Merged
Merged: 2/5/2025
Merged by: @georgemoralis

Base: main ← Head: remap-fix-input-overload

📝 Commits (4)

ebb62d7 Add axis noise filter + only update outputs if a change happened
1d299e3 Change the ring buffer size to 32 as seen in Ghidra
727c826 Merge remote/tracking branch origin/main
926d770 Fix merge

📊 Changes

2 files changed (+30 additions, -23 deletions)

View changed files

📝 src/input/controller.h (+1 -1)
📝 src/input/input_handler.cpp (+29 -22)

📄 Description

Adds an axis noise filter and only updates outputs if a change happened to that output, meaning that there are now both less axis movement event spam, and now every input event only updates one output, instead of updating all of them with all but the updated one holding duplicate data from the previous entry, which was making the ring buffer holding input events being overloaded in two different ways. These features were once in my main remap PR, but I had to revert them, although it looks like whatever was the issue that led to that no longer applies, as from my testing, I couldn't find any significant regressions, but just to be safe, I'll open this as a draft and wait until it's tested on more games.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2346 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 2/4/2025 **Status:** ✅ Merged **Merged:** 2/5/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `remap-fix-input-overload` --- ### 📝 Commits (4) - [`ebb62d7`](https://github.com/shadps4-emu/shadPS4/commit/ebb62d724f09170e505cf76825f6501fb1120f4b) Add axis noise filter + only update outputs if a change happened - [`1d299e3`](https://github.com/shadps4-emu/shadPS4/commit/1d299e30d700984a51fdfd1b6afab1288c700e5f) Change the ring buffer size to 32 as seen in Ghidra - [`727c826`](https://github.com/shadps4-emu/shadPS4/commit/727c8261e2980142f923af725665172462abc891) Merge remote/tracking branch origin/main - [`926d770`](https://github.com/shadps4-emu/shadPS4/commit/926d77072e3c8b0e96c7a048da4e25bd718f7190) Fix merge ### 📊 Changes **2 files changed** (+30 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `src/input/controller.h` (+1 -1) 📝 `src/input/input_handler.cpp` (+29 -22) </details> ### 📄 Description Adds an axis noise filter and only updates outputs if a change happened to that output, meaning that there are now both less axis movement event spam, and now every input event only updates one output, instead of updating all of them with all but the updated one holding duplicate data from the previous entry, which was making the ring buffer holding input events being overloaded in two different ways. These features were once in my main remap PR, but I had to revert them, although it looks like whatever was the issue that led to that no longer applies, as from my testing, I couldn't find any significant regressions, but just to be safe, I'll open this as a draft and wait until it's tested on more games. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>