[PR #1853] [MERGED] Fix AutoUpdate Issue with Non-Latin Usernames/Directories #2346

New issue

Closed

opened 2026-02-27 21:16:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1853
Author: @DanielSvoboda
Created: 12/22/2024
Status: ✅ Merged
Merged: 12/23/2024
Merged by: @georgemoralis

Base: main ← Head: main

📝 Commits (2)

b799f27 Fix updater for non-Latin user directories
530267e QStandardPaths

📊 Changes

1 file changed (+8 additions, -3 deletions)

View changed files

📝 src/qt_gui/check_update.cpp (+8 -3)

📄 Description

With this update, users who have usernames with Russian or other non-Latin characters can now use AutoUpdate without encountering the error shown in the image below.

UTF-8 BOM Encoding for .ps1 File
- The .ps1 file containing PowerShell commands is now saved with UTF-8 BOM encoding.
- Added scriptFile.write("\xEF\xBB\xBF"); to ensure the correct encoding.
Fix for Non-Latin Characters in Folder Paths
- The change to use QStandardPaths::writableLocation ensures proper handling of non-Latin characters (e.g., Russian characters) in folder paths.
- Previously, the old method failed to recognize and display these characters correctly.
Temporary Folder Path Update
- The temporary download location has been changed due to the use of this code, from::
```
AppData/Local/Temp/temp_download_update
```
  to:
```
AppData/Roaming/shadps4/Temp/temp_download_update
```

Testing

Print of the test I did with the code running in a folder in Russian (Администратор)
It was also tested by a user on discord who presented the problem, and with his user it worked correctly.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1853 **Author:** [@DanielSvoboda](https://github.com/DanielSvoboda) **Created:** 12/22/2024 **Status:** ✅ Merged **Merged:** 12/23/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`b799f27`](https://github.com/shadps4-emu/shadPS4/commit/b799f2747aeea0019bafe1b08d55794747863413) Fix updater for non-Latin user directories - [`530267e`](https://github.com/shadps4-emu/shadPS4/commit/530267e6d1a6af225a05ea76a90fddbe18d3d74c) QStandardPaths ### 📊 Changes **1 file changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/check_update.cpp` (+8 -3) </details> ### 📄 Description With this update, users who have usernames with Russian or other non-Latin characters can now use AutoUpdate without encountering the error shown in the image below. 1. **UTF-8 BOM Encoding for .ps1 File** - The `.ps1` file containing PowerShell commands is now saved with UTF-8 BOM encoding. - Added `scriptFile.write("\xEF\xBB\xBF");` to ensure the correct encoding. 2. **Fix for Non-Latin Characters in Folder Paths** - The change to use `QStandardPaths::writableLocation` ensures proper handling of non-Latin characters (e.g., Russian characters) in folder paths. - Previously, the old method failed to recognize and display these characters correctly. 3. **Temporary Folder Path Update** - The temporary download location has been changed due to the use of this code, from:: ``` AppData/Local/Temp/temp_download_update ``` to: ``` AppData/Roaming/shadps4/Temp/temp_download_update ``` ![Error Screenshot](https://github.com/user-attachments/assets/ac3fde03-8f1f-4e35-9a5e-18750dcdbd99) ### Testing - Print of the test I did with the code running in a folder in Russian (Администратор) ![Test Screenshot](https://github.com/user-attachments/assets/e534b047-d74d-477b-8fd9-92693995752a) - It was also tested by a user on discord who presented the problem, and with his user it worked correctly. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>