[PR #2291] [MERGED] Fix crash if remote is not set #2627

Closed
opened 2026-02-27 22:00:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2291
Author: @kalaposfos13
Created: 1/30/2025
Status: Merged
Merged: 1/30/2025
Merged by: @georgemoralis

Base: mainHead: fork-detection-fix


📝 Commits (1)

  • 35998ac Fix ccrash if remote is not set

📊 Changes

3 files changed (+14 additions, -6 deletions)

View changed files

📝 CMakeLists.txt (+10 -4)
📝 src/emulator.cpp (+2 -1)
📝 src/qt_gui/main_window.cpp (+2 -1)

📄 Description

Should fix some errors with local branches not having remotes set, and also add a fallback if an error occurs anyway so it doesn't crash on a null string


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2291 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 1/30/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fork-detection-fix` --- ### 📝 Commits (1) - [`35998ac`](https://github.com/shadps4-emu/shadPS4/commit/35998acab6875db78e1c540530f6d4eca056920e) Fix ccrash if remote is not set ### 📊 Changes **3 files changed** (+14 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+10 -4) 📝 `src/emulator.cpp` (+2 -1) 📝 `src/qt_gui/main_window.cpp` (+2 -1) </details> ### 📄 Description Should fix some errors with local branches not having remotes set, and also add a fallback if an error occurs anyway so it doesn't crash on a null string --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:00:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2627
No description provided.