[PR #2277] [MERGED] Fix issue #1684 #2617

New issue

Closed

opened 2026-02-27 22:00:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2277
Author: @pablodrake
Created: 1/30/2025
Status: ✅ Merged
Merged: 1/31/2025
Merged by: @georgemoralis

Base: main ← Head: fix-issue-1684

📝 Commits (5)

abafd68 Added recursive game scan and only using game directories
be46e4c Added recursion depth limit to scan directories
5ad8aeb Added recursive search by ID in cli mode
79cebcb Added recursive search to pkg installing
3ba53b4 Merge branch 'main' into fix-issue-1684

📊 Changes

6 files changed (+117 additions, -20 deletions)

View changed files

📝 src/common/path_util.cpp (+28 -0)
📝 src/common/path_util.h (+15 -0)
📝 src/main.cpp (+4 -4)
📝 src/qt_gui/game_info.cpp (+28 -7)
📝 src/qt_gui/main.cpp (+4 -4)
📝 src/qt_gui/main_window.cpp (+38 -5)

📄 Description

Pull request to fix issue https://github.com/shadps4-emu/shadPS4/issues/1684.

I tested and everything seems to work fine, also this fixes detecting normal folders as game folders and them showing up in the game list.

The max recursion depth const variables could maybe be refactored into a config variable so the user is able to customize it? If this is wanted I can do it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2277 **Author:** [@pablodrake](https://github.com/pablodrake) **Created:** 1/30/2025 **Status:** ✅ Merged **Merged:** 1/31/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-issue-1684` --- ### 📝 Commits (5) - [`abafd68`](https://github.com/shadps4-emu/shadPS4/commit/abafd68a3d88d81335f7accd94572319ba737a17) Added recursive game scan and only using game directories - [`be46e4c`](https://github.com/shadps4-emu/shadPS4/commit/be46e4c103a82386cbd5bddf54a0b90fb5707e1d) Added recursion depth limit to scan directories - [`5ad8aeb`](https://github.com/shadps4-emu/shadPS4/commit/5ad8aeb30c2a5f56b9a9260f6fc384a5b409ff7d) Added recursive search by ID in cli mode - [`79cebcb`](https://github.com/shadps4-emu/shadPS4/commit/79cebcbef4e5a4e4388f5743c60b11c891a51c56) Added recursive search to pkg installing - [`3ba53b4`](https://github.com/shadps4-emu/shadPS4/commit/3ba53b42a4a1d4ac4973b1155e81879afc1da08f) Merge branch 'main' into fix-issue-1684 ### 📊 Changes **6 files changed** (+117 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/common/path_util.cpp` (+28 -0) 📝 `src/common/path_util.h` (+15 -0) 📝 `src/main.cpp` (+4 -4) 📝 `src/qt_gui/game_info.cpp` (+28 -7) 📝 `src/qt_gui/main.cpp` (+4 -4) 📝 `src/qt_gui/main_window.cpp` (+38 -5) </details> ### 📄 Description Pull request to fix issue https://github.com/shadps4-emu/shadPS4/issues/1684. I tested and everything seems to work fine, also this fixes detecting normal folders as game folders and them showing up in the game list. The max recursion depth const variables could maybe be refactored into a config variable so the user is able to customize it? If this is wanted I can do it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>