[PR #1755] [MERGED] renderer_vulkan: Fix some color attachment indexing issues. #2277

New issue

Closed

opened 2026-02-27 21:15:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1755
Author: @squidbus
Created: 12/12/2024
Status: ✅ Merged
Merged: 12/12/2024
Merged by: @raphaelthegreat

Base: main ← Head: mrt-fix

📝 Commits (1)

d863c44 renderer_vulkan: Fix some color attachment indexing issues.

📊 Changes

5 files changed (+30 additions, -15 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+3 -5)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+1 -0)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+24 -10)
📝 src/video_core/renderer_vulkan/vk_platform.cpp (+1 -0)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+1 -0)

📄 Description

For both of the cases where attachment bindings are skipped, due to color_target_mask and shader mrt_mask, make sure that:
- The render target binding is VK_NULL_HANDLE.
- The format is set to undefined and the attachment index is skipped over in color attachment info passes.
Keep a counter of the number of color attachments in the pipeline key, as std::ranges::find(key.color_formats, vk::Format::eUndefined) is not sufficient when there are potentially undefined attachments in between defined attachments.
Silence validation warning about stores to undefined output when masked out by color_target_mask.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1755 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/12/2024 **Status:** ✅ Merged **Merged:** 12/12/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `mrt-fix` --- ### 📝 Commits (1) - [`d863c44`](https://github.com/shadps4-emu/shadPS4/commit/d863c44cb75788b5f5f24082a75fdf0dfdf29ea7) renderer_vulkan: Fix some color attachment indexing issues. ### 📊 Changes **5 files changed** (+30 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+3 -5) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+24 -10) 📝 `src/video_core/renderer_vulkan/vk_platform.cpp` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+1 -0) </details> ### 📄 Description * For both of the cases where attachment bindings are skipped, due to `color_target_mask` and shader `mrt_mask`, make sure that: * The render target binding is `VK_NULL_HANDLE`. * The format is set to undefined and the attachment index is skipped over in color attachment info passes. * Keep a counter of the number of color attachments in the pipeline key, as `std::ranges::find(key.color_formats, vk::Format::eUndefined)` is not sufficient when there are potentially undefined attachments in between defined attachments. * Silence validation warning about stores to undefined output when masked out by `color_target_mask`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>