[PR #2195] [MERGED] Additional libSceNpManager functions and cleanup #2553

New issue

Closed

opened 2026-02-27 22:00:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2195
Author: @StevenMiller123
Created: 1/20/2025
Status: ✅ Merged
Merged: 1/20/2025
Merged by: @squidbus

Base: main ← Head: np-fixes

📝 Commits (10+)

11192d0 Error return on sceNpGetAccountIdA
72255f7 Fix compile
9fac6c7 Move errors to separate file
64684f9 Cleanup function headers
38a8f51 Add proper parameter checks
3a2bd69 Implement sceNpGetAccountId
696b898 Implement sceNpHasSignedUp
2d21c74 Fix sceNpGetAccountId
fc4dc99 Update np_manager.cpp
ac65541 Merge remote-tracking branch 'upstream/main' into np-fixes

📊 Changes

3 files changed (+47 additions, -18 deletions)

View changed files

📝 src/core/libraries/np_manager/np_manager.cpp (+32 -10)
📝 src/core/libraries/np_manager/np_manager.h (+6 -8)
➕ src/core/libraries/np_manager/np_manager_error.h (+9 -0)

📄 Description

This PR implements sceNpGetAccountId, sceNpGetAccountIdA, and sceNpHasSignedUp based on observed PS4 behavior. Function parameters were based on fpPS4 code.
I've also added null parameter checks to various implemented NpManager functions, and cleaned up various parts of our NpManager code to make it better align with our current coding practices.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2195 **Author:** [@StevenMiller123](https://github.com/StevenMiller123) **Created:** 1/20/2025 **Status:** ✅ Merged **Merged:** 1/20/2025 **Merged by:** [@squidbus](https://github.com/squidbus) **Base:** `main` ← **Head:** `np-fixes` --- ### 📝 Commits (10+) - [`11192d0`](https://github.com/shadps4-emu/shadPS4/commit/11192d03c9b4758b8276145c886e0c5d46219c60) Error return on sceNpGetAccountIdA - [`72255f7`](https://github.com/shadps4-emu/shadPS4/commit/72255f7b72e3a796584676eab6744e1ec59e0ede) Fix compile - [`9fac6c7`](https://github.com/shadps4-emu/shadPS4/commit/9fac6c774aaefc47bd28bd306037a81f870a60bc) Move errors to separate file - [`64684f9`](https://github.com/shadps4-emu/shadPS4/commit/64684f9c48eedc667b8f01085434f493fceb67bd) Cleanup function headers - [`38a8f51`](https://github.com/shadps4-emu/shadPS4/commit/38a8f51932324d2ccc2c7394f4730ce3a01fda10) Add proper parameter checks - [`3a2bd69`](https://github.com/shadps4-emu/shadPS4/commit/3a2bd696559cc556b93c16ba34b805464b5fc1de) Implement sceNpGetAccountId - [`696b898`](https://github.com/shadps4-emu/shadPS4/commit/696b8981df14a6d379550998aba2f14a9cf8c8fa) Implement sceNpHasSignedUp - [`2d21c74`](https://github.com/shadps4-emu/shadPS4/commit/2d21c7477969ca4afe1b072e03f17095de4c7fc2) Fix sceNpGetAccountId - [`fc4dc99`](https://github.com/shadps4-emu/shadPS4/commit/fc4dc99e6722751de7fdf59a29ade45d4ec66f5c) Update np_manager.cpp - [`ac65541`](https://github.com/shadps4-emu/shadPS4/commit/ac6554148f4c0ef6404d57afa9082fb8d5a425b7) Merge remote-tracking branch 'upstream/main' into np-fixes ### 📊 Changes **3 files changed** (+47 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/np_manager/np_manager.cpp` (+32 -10) 📝 `src/core/libraries/np_manager/np_manager.h` (+6 -8) ➕ `src/core/libraries/np_manager/np_manager_error.h` (+9 -0) </details> ### 📄 Description This PR implements sceNpGetAccountId, sceNpGetAccountIdA, and sceNpHasSignedUp based on observed PS4 behavior. Function parameters were based on fpPS4 code. I've also added null parameter checks to various implemented NpManager functions, and cleaned up various parts of our NpManager code to make it better align with our current coding practices. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>