[PR #2188] [MERGED] Fix SurfaceFormat Format1_5_5_5 #2549

Closed
opened 2026-02-27 22:00:21 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2188
Author: @DanielSvoboda
Created: 1/19/2025
Status: Merged
Merged: 1/19/2025
Merged by: @georgemoralis

Base: mainHead: FIX_SurfaceFormat


📝 Commits (1)

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/video_core/renderer_vulkan/liverpool_to_vk.cpp (+1 -1)

📄 Description

Fix Castlevania: Symphony of the Night

Format1_5_5_5
From:  eR5G5B5A1UnormPack16
To:      eA1B5G5R5UnormPack16

Before After
image image

[Render.Vulkan] vk_platform.cpp:DebugUtilsCallback:52: VUID-VkImageViewCreateInfo-usage-08931: Validation Error: [ VUID-VkImageViewCreateInfo-usage-08931 ] Object 0: handle = 0x9675f10000000107, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0xca93720b | vkCreateImageView(): pCreateInfo->

format VK_FORMAT_R5G5B5A1_UNORM_PACK16 with tiling VK_IMAGE_TILING_OPTIMAL doesn't support VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT.
(supported features: VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_BIT|VK_FORMAT_FEATURE_2_BLIT_SRC_BIT|VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_LINEAR_BIT|VK_FORMAT_FEATURE_2_TRANSFER_SRC_BIT|VK_FORMAT_FEATURE_2_TRANSFER_DST_BIT|VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_MINMAX_BIT|VK_FORMAT_FEATURE_2_HOST_IMAGE_TRANSFER_BIT_EXT).
The Vulkan spec states: If usage contains VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, then the image view's format features must contain VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT or VK_FORMAT_FEATURE_2_LINEAR_COLOR_ATTACHMENT_BIT_NV (https://vulkan.lunarg.com/doc/view/1.3.283.0/windows/1.3-extensions/vkspec.html#VUID-VkImageViewCreateInfo-usage-08931)


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2188 **Author:** [@DanielSvoboda](https://github.com/DanielSvoboda) **Created:** 1/19/2025 **Status:** ✅ Merged **Merged:** 1/19/2025 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `FIX_SurfaceFormat` --- ### 📝 Commits (1) - [`921b1dc`](https://github.com/shadps4-emu/shadPS4/commit/921b1dc5a6cd05b3493c99c4dadc41715cad4fe0) Fix SurfaceFormat ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.cpp` (+1 -1) </details> ### 📄 Description Fix `Castlevania: Symphony of the Night` Format1_5_5_5 From:  eR5G5B5A1UnormPack16 To:      eA1B5G5R5UnormPack16 | Before | After | |-------------|-------------| ![image](https://github.com/user-attachments/assets/1573587a-837a-4059-ad42-0463afc7d25a) | ![image](https://github.com/user-attachments/assets/9bbb1b6f-3a86-4415-8747-9b0d3079256f) [Render.Vulkan] <Error> vk_platform.cpp:DebugUtilsCallback:52: VUID-VkImageViewCreateInfo-usage-08931: Validation Error: [ VUID-VkImageViewCreateInfo-usage-08931 ] Object 0: handle = 0x9675f10000000107, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0xca93720b | vkCreateImageView(): pCreateInfo-> format VK_FORMAT_R5G5B5A1_UNORM_PACK16 with tiling VK_IMAGE_TILING_OPTIMAL doesn't support VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT. (supported features: VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_BIT|VK_FORMAT_FEATURE_2_BLIT_SRC_BIT|VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_LINEAR_BIT|VK_FORMAT_FEATURE_2_TRANSFER_SRC_BIT|VK_FORMAT_FEATURE_2_TRANSFER_DST_BIT|VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_MINMAX_BIT|VK_FORMAT_FEATURE_2_HOST_IMAGE_TRANSFER_BIT_EXT). The Vulkan spec states: If usage contains VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, then the image view's format features must contain VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT or VK_FORMAT_FEATURE_2_LINEAR_COLOR_ATTACHMENT_BIT_NV (https://vulkan.lunarg.com/doc/view/1.3.283.0/windows/1.3-extensions/vkspec.html#VUID-VkImageViewCreateInfo-usage-08931) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:00:21 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2549
No description provided.