mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 08:15:59 +03:00
[PR #2188] [MERGED] Fix SurfaceFormat Format1_5_5_5 #2549
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#2549
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/2188
Author: @DanielSvoboda
Created: 1/19/2025
Status: ✅ Merged
Merged: 1/19/2025
Merged by: @georgemoralis
Base:
main← Head:FIX_SurfaceFormat📝 Commits (1)
921b1dcFix SurfaceFormat📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
src/video_core/renderer_vulkan/liverpool_to_vk.cpp(+1 -1)📄 Description
Fix
Castlevania: Symphony of the NightFormat1_5_5_5
From: eR5G5B5A1UnormPack16
To: eA1B5G5R5UnormPack16
[Render.Vulkan] vk_platform.cpp:DebugUtilsCallback:52: VUID-VkImageViewCreateInfo-usage-08931: Validation Error: [ VUID-VkImageViewCreateInfo-usage-08931 ] Object 0: handle = 0x9675f10000000107, type = VK_OBJECT_TYPE_IMAGE; | MessageID = 0xca93720b | vkCreateImageView(): pCreateInfo->
format VK_FORMAT_R5G5B5A1_UNORM_PACK16 with tiling VK_IMAGE_TILING_OPTIMAL doesn't support VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT.
(supported features: VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_BIT|VK_FORMAT_FEATURE_2_BLIT_SRC_BIT|VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_LINEAR_BIT|VK_FORMAT_FEATURE_2_TRANSFER_SRC_BIT|VK_FORMAT_FEATURE_2_TRANSFER_DST_BIT|VK_FORMAT_FEATURE_2_SAMPLED_IMAGE_FILTER_MINMAX_BIT|VK_FORMAT_FEATURE_2_HOST_IMAGE_TRANSFER_BIT_EXT).
The Vulkan spec states: If usage contains VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, then the image view's format features must contain VK_FORMAT_FEATURE_COLOR_ATTACHMENT_BIT or VK_FORMAT_FEATURE_2_LINEAR_COLOR_ATTACHMENT_BIT_NV (https://vulkan.lunarg.com/doc/view/1.3.283.0/windows/1.3-extensions/vkspec.html#VUID-VkImageViewCreateInfo-usage-08931)
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.