[PR #1593] [MERGED] implement DS_AND_B32, DS_OR_B32, DS_XOR_B32 #2188

New issue

Closed

opened 2026-02-27 21:15:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1593
Author: @f8ith
Created: 11/25/2024
Status: ✅ Merged
Merged: 11/30/2024
Merged by: @raphaelthegreat

Base: main ← Head: data-sharing

📝 Commits (2)

07d537a implement DS_OR_B32
6c4383c implement DS_AND_B32, DS_XOR_B32

📊 Changes

8 files changed (+88 additions, -0 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_atomic.cpp (+12 -0)
📝 src/shader_recompiler/backend/spirv/emit_spirv_instructions.h (+3 -0)
📝 src/shader_recompiler/frontend/translate/data_share.cpp (+49 -0)
📝 src/shader_recompiler/frontend/translate/translate.h (+3 -0)
📝 src/shader_recompiler/ir/ir_emitter.cpp (+12 -0)
📝 src/shader_recompiler/ir/ir_emitter.h (+3 -0)
📝 src/shader_recompiler/ir/microinstruction.cpp (+3 -0)
📝 src/shader_recompiler/ir/opcodes.inc (+3 -0)

📄 Description

Addresses https://github.com/shadps4-emu/shadPS4/issues/496#issuecomment-2492526224

None of the data sharing B64 instructions have been implemented yet, not sure how to implement it properly as it seems like the emulator specially handles B64 (e.g. V_LSHR_B64)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1593 **Author:** [@f8ith](https://github.com/f8ith) **Created:** 11/25/2024 **Status:** ✅ Merged **Merged:** 11/30/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `data-sharing` --- ### 📝 Commits (2) - [`07d537a`](https://github.com/shadps4-emu/shadPS4/commit/07d537a104d8540629b1c59106e6f4c21ea6c1b7) implement DS_OR_B32 - [`6c4383c`](https://github.com/shadps4-emu/shadPS4/commit/6c4383cba41399cb820541c622f7cc0ff4f02fbc) implement DS_AND_B32, DS_XOR_B32 ### 📊 Changes **8 files changed** (+88 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_atomic.cpp` (+12 -0) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_instructions.h` (+3 -0) 📝 `src/shader_recompiler/frontend/translate/data_share.cpp` (+49 -0) 📝 `src/shader_recompiler/frontend/translate/translate.h` (+3 -0) 📝 `src/shader_recompiler/ir/ir_emitter.cpp` (+12 -0) 📝 `src/shader_recompiler/ir/ir_emitter.h` (+3 -0) 📝 `src/shader_recompiler/ir/microinstruction.cpp` (+3 -0) 📝 `src/shader_recompiler/ir/opcodes.inc` (+3 -0) </details> ### 📄 Description Addresses https://github.com/shadps4-emu/shadPS4/issues/496#issuecomment-2492526224 None of the data sharing B64 instructions have been implemented yet, not sure how to implement it properly as it seems like the emulator specially handles B64 (e.g. `V_LSHR_B64`) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>