[PR #2178] [CLOSED] Revert "input: Don't use old input state in GameController::ReadState() (#2170)" #2539

New issue

Closed

opened 2026-02-27 22:00:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 22:00:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2178
Author: @kalaposfos13
Created: 1/18/2025
Status: ❌ Closed

Base: main ← Head: revert-input-refactor

📝 Commits (1)

9c48e5c Revert "input: Don't use old input state in GameController::ReadState() (#2170)"

📊 Changes

5 files changed (+112 additions, -321 deletions)

View changed files

📝 src/core/libraries/pad/pad.cpp (+10 -23)
📝 src/input/controller.cpp (+69 -77)
📝 src/input/controller.h (+10 -26)
📝 src/sdl_window.cpp (+21 -175)
📝 src/sdl_window.h (+2 -20)

📄 Description

This PR, while it reduces input lag, also makes the keyboard nonfunctional, and also makes WindowSDL::WaitEvent unused apart from controllers connecting and disconnecting, but does not remove it. It also completely breaks my remapping PR, both for controllers and KBM.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2178 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 1/18/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `revert-input-refactor` --- ### 📝 Commits (1) - [`9c48e5c`](https://github.com/shadps4-emu/shadPS4/commit/9c48e5cfb7646afae7ffbd4dd6507132cc038a2a) Revert "input: Don't use old input state in GameController::ReadState() (#2170)" ### 📊 Changes **5 files changed** (+112 additions, -321 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/pad/pad.cpp` (+10 -23) 📝 `src/input/controller.cpp` (+69 -77) 📝 `src/input/controller.h` (+10 -26) 📝 `src/sdl_window.cpp` (+21 -175) 📝 `src/sdl_window.h` (+2 -20) </details> ### 📄 Description This PR, while it reduces input lag, also makes the keyboard nonfunctional, and also makes WindowSDL::WaitEvent unused apart from controllers connecting and disconnecting, but does not remove it. It also completely breaks my remapping PR, both for controllers and KBM. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>