[PR #1557] [MERGED] Fixed false-positive image reuploads #2170

New issue

Closed

opened 2026-02-27 21:15:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1557
Author: @roamic
Created: 11/20/2024
Status: ✅ Merged
Merged: 11/26/2024
Merged by: @georgemoralis

Base: main ← Head: fix-false-positive-image-reuploads

📝 Commits (7)

0f99682 Fixed false-positive image reuploads
6657a7b Fixed userfaultfd path, removed dead code, simplified calculations
7ac7398 oopsie
7936dd7 track potentially dirty images and hash them
da28623 untrack only first page of the image in case of head access
ec10c5d rebase, initialize hash, fix bounds check
1772826 include image tail in the calculations

📊 Changes

9 files changed (+196 additions, -40 deletions)

View changed files

📝 src/video_core/buffer_cache/buffer_cache.cpp (+1 -1)
📝 src/video_core/page_manager.cpp (+12 -4)
📝 src/video_core/page_manager.h (+3 -0)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+3 -3)
📝 src/video_core/renderer_vulkan/vk_rasterizer.h (+1 -1)
📝 src/video_core/texture_cache/image.cpp (+1 -2)
📝 src/video_core/texture_cache/image.h (+14 -6)
📝 src/video_core/texture_cache/texture_cache.cpp (+154 -22)
📝 src/video_core/texture_cache/texture_cache.h (+7 -1)

📄 Description

Should fix half of the rainbow artifacts in BloodBorne.
Big thanks to @raphaelthegreat and @psucien for helping debug and fix this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1557 **Author:** [@roamic](https://github.com/roamic) **Created:** 11/20/2024 **Status:** ✅ Merged **Merged:** 11/26/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-false-positive-image-reuploads` --- ### 📝 Commits (7) - [`0f99682`](https://github.com/shadps4-emu/shadPS4/commit/0f99682eb60a00ec09fcb6df6cf4e3ef0ea7aadc) Fixed false-positive image reuploads - [`6657a7b`](https://github.com/shadps4-emu/shadPS4/commit/6657a7bafa686e2a3f82220318bfb83d26f92419) Fixed userfaultfd path, removed dead code, simplified calculations - [`7ac7398`](https://github.com/shadps4-emu/shadPS4/commit/7ac7398ab484edfb276aa715061953bd40dcb8e1) oopsie - [`7936dd7`](https://github.com/shadps4-emu/shadPS4/commit/7936dd7386acfae8e2d7ae4886a4bb6692fd716a) track potentially dirty images and hash them - [`da28623`](https://github.com/shadps4-emu/shadPS4/commit/da28623315b3a25e5eff5fef429694d9302b7cfb) untrack only first page of the image in case of head access - [`ec10c5d`](https://github.com/shadps4-emu/shadPS4/commit/ec10c5d94be7c84b407c7895ae8cbb7c6ecedf3e) rebase, initialize hash, fix bounds check - [`1772826`](https://github.com/shadps4-emu/shadPS4/commit/17728267ff79d43c817443d4c6b76e720fddfbda) include image tail in the calculations ### 📊 Changes **9 files changed** (+196 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/buffer_cache/buffer_cache.cpp` (+1 -1) 📝 `src/video_core/page_manager.cpp` (+12 -4) 📝 `src/video_core/page_manager.h` (+3 -0) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+3 -3) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.h` (+1 -1) 📝 `src/video_core/texture_cache/image.cpp` (+1 -2) 📝 `src/video_core/texture_cache/image.h` (+14 -6) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+154 -22) 📝 `src/video_core/texture_cache/texture_cache.h` (+7 -1) </details> ### 📄 Description Should fix half of the rainbow artifacts in BloodBorne. Big thanks to @raphaelthegreat and @psucien for helping debug and fix this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>