[PR #2103] [MERGED] qt: Improve user experience on Steam Deck and window managers #2492

Closed
opened 2026-02-27 22:00:07 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/2103
Author: @tomboylover93
Created: 1/9/2025
Status: Merged
Merged: 1/18/2025
Merged by: @roamic

Base: mainHead: ui-fixes


📝 Commits (10+)

  • bd59bf5 Use more screen real estate for the 'General' settings tab
  • b347635 Fixup minor issues with the 'Advanced' group box in the 'Debug' tab
  • d78244c Remove spacer in 'Paths' tab
  • 4abb25a Re-add license text
  • 7ca14c4 Make 'Save' button in 'Patches' section of 'Cheats and Patches' window close the window when clicked
  • 0c16a28 Add 'Close' button to 'Cheats' tab of 'Cheats and Patches' window
  • 2fb410b clang-format
  • 0c78d0c Make size of text box in 'Settings' window fixed
  • 189d6e8 Change bottomMargin in UpdateLayout from 11 to 190
  • 6b191ae Merge branch 'main' into ui-fixes

📊 Changes

3 files changed (+243 additions, -274 deletions)

View changed files

📝 src/qt_gui/cheats_patches.cpp (+6 -0)
📝 src/qt_gui/settings_dialog.cpp (+0 -16)
📝 src/qt_gui/settings_dialog.ui (+237 -258)

📄 Description

This aims to fix issues with the Qt interface on (mostly Linux) desktops that hide the app's titlebar and buttons, such as the Steam Deck's Gaming Mode, which uses Gamescope (see #2086), and the aforementioned window managers. They range from minor quirks to issues that make it outright impossible to perform some actions solely using the GUI, and some examples are:

  • the lack of a "Close" button for the Cheats/Patches window, and
  • the Settings window resizing itself when hovering over something whose description text occupies more screen real estate than 70px:

https://github.com/user-attachments/assets/4804a2e6-7746-4408-8b68-caecf5b3e816

The latter causes weird behavior outside of those desktop interfaces, as when maximizing the Settings window on any desktop environment the text box resizing mechanism does not respect the actual window size, which leads to this:

image

I'll leave it as a draft for now because I want more input from people using said desktops and other operating systems than Linux, since there might be something I missed or that needs to be changed.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/2103 **Author:** [@tomboylover93](https://github.com/tomboylover93) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/18/2025 **Merged by:** [@roamic](https://github.com/roamic) **Base:** `main` ← **Head:** `ui-fixes` --- ### 📝 Commits (10+) - [`bd59bf5`](https://github.com/shadps4-emu/shadPS4/commit/bd59bf51df0f0d083bfd79b75215861abef1c3f9) Use more screen real estate for the 'General' settings tab - [`b347635`](https://github.com/shadps4-emu/shadPS4/commit/b347635c8e2fade115fe6cd70f8c609b69540c34) Fixup minor issues with the 'Advanced' group box in the 'Debug' tab - [`d78244c`](https://github.com/shadps4-emu/shadPS4/commit/d78244c0d300e1f7a5f66c34a86a8e9c1dcdbcf0) Remove spacer in 'Paths' tab - [`4abb25a`](https://github.com/shadps4-emu/shadPS4/commit/4abb25a1fc373d2be6152c711418663f4ba68056) Re-add license text - [`7ca14c4`](https://github.com/shadps4-emu/shadPS4/commit/7ca14c4d26a26190c65155e6778666a041212751) Make 'Save' button in 'Patches' section of 'Cheats and Patches' window close the window when clicked - [`0c16a28`](https://github.com/shadps4-emu/shadPS4/commit/0c16a28baf8c21ddbe8eb366399f0b5ac3ff6872) Add 'Close' button to 'Cheats' tab of 'Cheats and Patches' window - [`2fb410b`](https://github.com/shadps4-emu/shadPS4/commit/2fb410b548ec8c07aabbc36c707cb704f93c0886) clang-format - [`0c78d0c`](https://github.com/shadps4-emu/shadPS4/commit/0c78d0c1c7e7100d0cb7e79318c8cf9f6fb2604e) Make size of text box in 'Settings' window fixed - [`189d6e8`](https://github.com/shadps4-emu/shadPS4/commit/189d6e8192ef2845be263bea5330780d9a4f552c) Change bottomMargin in UpdateLayout from 11 to 190 - [`6b191ae`](https://github.com/shadps4-emu/shadPS4/commit/6b191ae0a28c8fabe065086be7e23f480c14f7b7) Merge branch 'main' into ui-fixes ### 📊 Changes **3 files changed** (+243 additions, -274 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/cheats_patches.cpp` (+6 -0) 📝 `src/qt_gui/settings_dialog.cpp` (+0 -16) 📝 `src/qt_gui/settings_dialog.ui` (+237 -258) </details> ### 📄 Description This aims to fix issues with the Qt interface on (mostly Linux) desktops that hide the app's titlebar and buttons, such as the Steam Deck's Gaming Mode, which uses Gamescope (see #2086), and the aforementioned window managers. They range from minor quirks to issues that make it outright impossible to perform some actions solely using the GUI, and some examples are: - the lack of a "Close" button for the Cheats/Patches window, and - the Settings window resizing itself when hovering over something whose description text occupies more screen real estate than 70px: https://github.com/user-attachments/assets/4804a2e6-7746-4408-8b68-caecf5b3e816 The latter causes weird behavior outside of those desktop interfaces, as when maximizing the Settings window on any desktop environment the text box resizing mechanism does not respect the actual window size, which leads to this: ![image](https://github.com/user-attachments/assets/7620a62f-8946-4861-9410-aff0fa48bb01) I'll leave it as a draft for now because I want more input from people using said desktops and other operating systems than Linux, since there might be something I missed or that needs to be changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 22:00:07 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#2492
No description provided.