[PR #1420] [MERGED] vulkan: Report only missing format feature flags. #2103

New issue

Closed

opened 2026-02-27 21:15:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1420
Author: @squidbus
Created: 10/20/2024
Status: ✅ Merged
Merged: 10/21/2024
Merged by: @georgemoralis

Base: main ← Head: format-report

📝 Commits (1)

d202dee vulkan: Report only missing format feature flags.

📊 Changes

2 files changed (+20 additions, -13 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_instance.cpp (+17 -13)
📝 src/video_core/renderer_vulkan/vk_instance.h (+3 -0)

📄 Description

Make format support logging more useful by reporting the flags that are actually unsupported instead of all requested flags.

Also don't bother trying the translation to a supported image format for reporting, just report on the base format since we want to know for more than just images. There was no effect anyway since neither of the formats checked would support all flags.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1420 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 10/20/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `format-report` --- ### 📝 Commits (1) - [`d202dee`](https://github.com/shadps4-emu/shadPS4/commit/d202dee948a2f939843c82189cb009dcd8448a03) vulkan: Report only missing format feature flags. ### 📊 Changes **2 files changed** (+20 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+17 -13) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+3 -0) </details> ### 📄 Description Make format support logging more useful by reporting the flags that are actually unsupported instead of all requested flags. Also don't bother trying the translation to a supported image format for reporting, just report on the base format since we want to know for more than just images. There was no effect anyway since neither of the formats checked would support all flags. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>