[PR #1993] [MERGED] vk_platform: Fix incorrect type for MVK debug flag. #2426

New issue

Closed

opened 2026-02-27 21:16:28 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:28 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1993
Author: @squidbus
Created: 12/31/2024
Status: ✅ Merged
Merged: 12/31/2024
Merged by: @georgemoralis

Base: main ← Head: mvk-type

📝 Commits (1)

17b52a9 vk_platform: Fix incorrect type for MVK debug flag.

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_platform.cpp (+4 -1)

📄 Description

Caught this with address sanitizer, the flag should be a 32-bit vk::Bool32 but a pointer to an 8-bit bool was being given instead. Mostly harmless but good to be correct here.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1993 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/31/2024 **Status:** ✅ Merged **Merged:** 12/31/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `mvk-type` --- ### 📝 Commits (1) - [`17b52a9`](https://github.com/shadps4-emu/shadPS4/commit/17b52a90b52dec49f775b797eeede5da41477aab) vk_platform: Fix incorrect type for MVK debug flag. ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_platform.cpp` (+4 -1) </details> ### 📄 Description Caught this with address sanitizer, the flag should be a 32-bit `vk::Bool32` but a pointer to an 8-bit `bool` was being given instead. Mostly harmless but good to be correct here. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>