[PR #1963] [CLOSED] cubeb_audio: Add failsafe timeout for output and more logging. #2406

New issue

Closed

opened 2026-02-27 21:16:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1963
Author: @squidbus
Created: 12/29/2024
Status: ❌ Closed

Base: main ← Head: cubeb-robust

📝 Commits (1)

7a402f2 cubeb_audio: Add failsafe timeout for output and more logging.

📊 Changes

2 files changed (+26 additions, -3 deletions)

View changed files

📝 src/core/libraries/audio/audioout_backend.h (+2 -0)
📝 src/core/libraries/audio/cubeb_audio.cpp (+24 -3)

📄 Description

Add a timeout to the cubeb ring buffer wait, up to two times the duration of an audio buffer, to try to avoid unexpected stalls.
If the wait timed out and not all audio data could be written, log the dropped frames.
Add log callback to get more information from cubeb.

@Emulator-Team-2 Please check what Disgaea 4 Complete does with this.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1963 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 12/29/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `cubeb-robust` --- ### 📝 Commits (1) - [`7a402f2`](https://github.com/shadps4-emu/shadPS4/commit/7a402f205c2f4ada837594f7e18b350899afb8bc) cubeb_audio: Add failsafe timeout for output and more logging. ### 📊 Changes **2 files changed** (+26 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/audio/audioout_backend.h` (+2 -0) 📝 `src/core/libraries/audio/cubeb_audio.cpp` (+24 -3) </details> ### 📄 Description * Add a timeout to the cubeb ring buffer wait, up to two times the duration of an audio buffer, to try to avoid unexpected stalls. * If the wait timed out and not all audio data could be written, log the dropped frames. * Add log callback to get more information from cubeb. @Emulator-Team-2 Please check what Disgaea 4 Complete does with this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>