[PR #1165] [MERGED] Implement shader resource tables #1963

New issue

Closed

opened 2026-02-27 21:14:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1165
Author: @baggins183
Created: 9/30/2024
Status: ✅ Merged
Merged: 11/1/2024
Merged by: @georgemoralis

Base: main ← Head: SRT

📝 Commits (6)

c4300dd Implement shader resource tables
e698810 fix after rebase + squash
57df6f1 address some review comments
2d54441 fix pipeline_common
539ecd2 cleanup debug stuff
99369a6 switch to using single codegenerator

📊 Changes

30 files changed (+740 additions, -119 deletions)

View changed files

📝 CMakeLists.txt (+1 -0)
📝 src/common/decoder.cpp (+11 -5)
📝 src/common/decoder.h (+2 -0)
➕ src/common/hash.h (+14 -0)
📝 src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp (+9 -3)
📝 src/shader_recompiler/backend/spirv/emit_spirv_instructions.h (+1 -1)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+35 -10)
📝 src/shader_recompiler/backend/spirv/spirv_emit_context.h (+1 -0)
📝 src/shader_recompiler/frontend/translate/scalar_memory.cpp (+4 -0)
📝 src/shader_recompiler/frontend/translate/translate.cpp (+2 -3)
📝 src/shader_recompiler/info.h (+33 -14)
📝 src/shader_recompiler/ir/basic_block.cpp (+4 -0)
📝 src/shader_recompiler/ir/breadth_first_search.h (+21 -9)
➕ src/shader_recompiler/ir/passes/flatten_extended_userdata_pass.cpp (+249 -0)
📝 src/shader_recompiler/ir/passes/ir_passes.h (+1 -0)
📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+27 -65)
📝 src/shader_recompiler/ir/passes/shader_info_collection_pass.cpp (+3 -0)
➕ src/shader_recompiler/ir/passes/srt.h (+37 -0)
➕ src/shader_recompiler/ir/srt_gvn_table.h (+157 -0)
📝 src/shader_recompiler/ir/value.cpp (+52 -1)

...and 10 more files

📄 Description

Leaving this in draft for regression testing

Still needs a lot of refactoring. Also handling arbitrary readconst usage (not used in sharps).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1165 **Author:** [@baggins183](https://github.com/baggins183) **Created:** 9/30/2024 **Status:** ✅ Merged **Merged:** 11/1/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `SRT` --- ### 📝 Commits (6) - [`c4300dd`](https://github.com/shadps4-emu/shadPS4/commit/c4300dd9aceb8b4d3144833240b061e5cd22951a) Implement shader resource tables - [`e698810`](https://github.com/shadps4-emu/shadPS4/commit/e69881033e6b2419d627dd239820049c072c0755) fix after rebase + squash - [`57df6f1`](https://github.com/shadps4-emu/shadPS4/commit/57df6f189f1e9efa0418f7e6ff9f9b39ebb94aa7) address some review comments - [`2d54441`](https://github.com/shadps4-emu/shadPS4/commit/2d54441ce4010289c72b31abc3613b4aa853d4d8) fix pipeline_common - [`539ecd2`](https://github.com/shadps4-emu/shadPS4/commit/539ecd211f610523c5297f4d2f2847e6d188eaa2) cleanup debug stuff - [`99369a6`](https://github.com/shadps4-emu/shadPS4/commit/99369a67e1ad4d9c06c1203a315d6ea216e80554) switch to using single codegenerator ### 📊 Changes **30 files changed** (+740 additions, -119 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+1 -0) 📝 `src/common/decoder.cpp` (+11 -5) 📝 `src/common/decoder.h` (+2 -0) ➕ `src/common/hash.h` (+14 -0) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp` (+9 -3) 📝 `src/shader_recompiler/backend/spirv/emit_spirv_instructions.h` (+1 -1) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+35 -10) 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.h` (+1 -0) 📝 `src/shader_recompiler/frontend/translate/scalar_memory.cpp` (+4 -0) 📝 `src/shader_recompiler/frontend/translate/translate.cpp` (+2 -3) 📝 `src/shader_recompiler/info.h` (+33 -14) 📝 `src/shader_recompiler/ir/basic_block.cpp` (+4 -0) 📝 `src/shader_recompiler/ir/breadth_first_search.h` (+21 -9) ➕ `src/shader_recompiler/ir/passes/flatten_extended_userdata_pass.cpp` (+249 -0) 📝 `src/shader_recompiler/ir/passes/ir_passes.h` (+1 -0) 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+27 -65) 📝 `src/shader_recompiler/ir/passes/shader_info_collection_pass.cpp` (+3 -0) ➕ `src/shader_recompiler/ir/passes/srt.h` (+37 -0) ➕ `src/shader_recompiler/ir/srt_gvn_table.h` (+157 -0) 📝 `src/shader_recompiler/ir/value.cpp` (+52 -1) _...and 10 more files_ </details> ### 📄 Description Leaving this in draft for regression testing Still needs a lot of refactoring. Also handling arbitrary readconst usage (not used in sharps). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>