[PR #1860] [MERGED] renderer_vulkan: fix deadlock when resizing the SDL window #2354

New issue

Closed

opened 2026-02-27 21:16:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1860
Author: @ngoquang2708
Created: 12/24/2024
Status: ✅ Merged
Merged: 12/29/2024
Merged by: @raphaelthegreat

Base: main ← Head: fix-window-resizing

📝 Commits (2)

5c23a8e renderer_vulkan: Fix deadlock when resizing the SDL window
ccbe410 Address review comment

📊 Changes

2 files changed (+20 additions, -8 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_presenter.cpp (+19 -8)
📝 src/video_core/renderer_vulkan/vk_swapchain.cpp (+1 -0)

📄 Description

Commit 400da1aa8d add ability to handle recreation of the swapchain which fix black screen under XWayland. Unfortunately, that commit doesn't account for rapid swapchain recreation caused by resizing window.

This commit aim to solve that issue by skipping frames to recreate the swapchain and delay resetting the frame's present done fence until after we know for sure we will be submitting work with it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1860 **Author:** [@ngoquang2708](https://github.com/ngoquang2708) **Created:** 12/24/2024 **Status:** ✅ Merged **Merged:** 12/29/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix-window-resizing` --- ### 📝 Commits (2) - [`5c23a8e`](https://github.com/shadps4-emu/shadPS4/commit/5c23a8e012baf048f72e358743dc2c5ea50e9a0c) renderer_vulkan: Fix deadlock when resizing the SDL window - [`ccbe410`](https://github.com/shadps4-emu/shadPS4/commit/ccbe410f359762042f078d0d9fe8815d3e287027) Address review comment ### 📊 Changes **2 files changed** (+20 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_presenter.cpp` (+19 -8) 📝 `src/video_core/renderer_vulkan/vk_swapchain.cpp` (+1 -0) </details> ### 📄 Description Commit 400da1aa8da376d38b3c4a086bc7f656f590de2e add ability to handle recreation of the swapchain which fix black screen under XWayland. Unfortunately, that commit doesn't account for rapid swapchain recreation caused by resizing window. This commit aim to solve that issue by skipping frames to recreate the swapchain and delay resetting the frame's present done fence until after we know for sure we will be submitting work with it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>