[PR #1797] [CLOSED] KBM-only remapping #2311

New issue

Closed

opened 2026-02-27 21:16:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:16:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1797
Author: @kalaposfos13
Created: 12/15/2024
Status: ❌ Closed

Base: main ← Head: kbm-only

📝 Commits (10+)

6f7bf0b Squashed commits
97e2f78 Partly address the review comments
346c5cc Clang
09856df More work on review comments
b02087a ^
9146ca0 Merge remote-tracking branch 'origin/main' into kbm-only
c5cde12 Merge remote-tracking branch 'origin/main' into kbm-only
9aec35b Refactor code
4ac5d17 Merge remote-tracking branch 'origin/main' into kbm-only
7e10d78 Workaround to make mouse input work with the game being inside an ImGui window

📊 Changes

17 files changed (+1840 additions, -215 deletions)

View changed files

📝 CMakeLists.txt (+8 -0)
📝 README.md (+29 -27)
📝 src/common/config.cpp (+77 -0)
📝 src/common/config.h (+3 -0)
📝 src/imgui/renderer/imgui_core.cpp (+1 -1)
📝 src/input/controller.cpp (+1 -1)
➕ src/input/input_handler.cpp (+613 -0)
➕ src/input/input_handler.h (+382 -0)
➕ src/input/input_mouse.cpp (+74 -0)
➕ src/input/input_mouse.h (+18 -0)
➕ src/qt_gui/kbm_config_dialog.cpp (+237 -0)
➕ src/qt_gui/kbm_config_dialog.h (+38 -0)
➕ src/qt_gui/kbm_help_dialog.cpp (+112 -0)
➕ src/qt_gui/kbm_help_dialog.h (+165 -0)
📝 src/qt_gui/main_window.cpp (+10 -0)
📝 src/sdl_window.cpp (+69 -185)
📝 src/sdl_window.h (+3 -1)

📄 Description

This is a modified version of my remapping PR that only contains the keyboard and mouse part, as this is already complete and has proven to be mostly bug-free, as it has been extensively tested by people using @diegolix29's fork. The controller part is still WIP and is not ready for merging yet, so until that's ready too, I'll just put this out here following @rainmakerv3's advice. The code still has some controller remapping elements left in, but they aren't hooked up to the main input loop. If I left in anything that I shouldn't have, please let me know.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1797 **Author:** [@kalaposfos13](https://github.com/kalaposfos13) **Created:** 12/15/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `kbm-only` --- ### 📝 Commits (10+) - [`6f7bf0b`](https://github.com/shadps4-emu/shadPS4/commit/6f7bf0b2a362b95292b5a74ea6278df1b843609f) Squashed commits - [`97e2f78`](https://github.com/shadps4-emu/shadPS4/commit/97e2f784ccdfee7a9474c0f65851f1223e8bec4e) Partly address the review comments - [`346c5cc`](https://github.com/shadps4-emu/shadPS4/commit/346c5ccf03b409d5b086e4cc1354ba6900046747) Clang - [`09856df`](https://github.com/shadps4-emu/shadPS4/commit/09856df67bee4fe59470a6b6ffec920a26b554b5) More work on review comments - [`b02087a`](https://github.com/shadps4-emu/shadPS4/commit/b02087af88e98534beac8f51b7390448717f42a3) ^ - [`9146ca0`](https://github.com/shadps4-emu/shadPS4/commit/9146ca01e96198a0ffb07d737a5ef2ffefb93a25) Merge remote-tracking branch 'origin/main' into kbm-only - [`c5cde12`](https://github.com/shadps4-emu/shadPS4/commit/c5cde12ee95ffdfe26690576a754a66d1d04e1f6) Merge remote-tracking branch 'origin/main' into kbm-only - [`9aec35b`](https://github.com/shadps4-emu/shadPS4/commit/9aec35b23e089b013b3dacd5732461f0508550ed) Refactor code - [`4ac5d17`](https://github.com/shadps4-emu/shadPS4/commit/4ac5d171c981b68aa9512c5fd8b128a41fe69423) Merge remote-tracking branch 'origin/main' into kbm-only - [`7e10d78`](https://github.com/shadps4-emu/shadPS4/commit/7e10d78341cd52ca0a6ff9e058f987f41264bcc6) Workaround to make mouse input work with the game being inside an ImGui window ### 📊 Changes **17 files changed** (+1840 additions, -215 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+8 -0) 📝 `README.md` (+29 -27) 📝 `src/common/config.cpp` (+77 -0) 📝 `src/common/config.h` (+3 -0) 📝 `src/imgui/renderer/imgui_core.cpp` (+1 -1) 📝 `src/input/controller.cpp` (+1 -1) ➕ `src/input/input_handler.cpp` (+613 -0) ➕ `src/input/input_handler.h` (+382 -0) ➕ `src/input/input_mouse.cpp` (+74 -0) ➕ `src/input/input_mouse.h` (+18 -0) ➕ `src/qt_gui/kbm_config_dialog.cpp` (+237 -0) ➕ `src/qt_gui/kbm_config_dialog.h` (+38 -0) ➕ `src/qt_gui/kbm_help_dialog.cpp` (+112 -0) ➕ `src/qt_gui/kbm_help_dialog.h` (+165 -0) 📝 `src/qt_gui/main_window.cpp` (+10 -0) 📝 `src/sdl_window.cpp` (+69 -185) 📝 `src/sdl_window.h` (+3 -1) </details> ### 📄 Description This is a modified version of my [remapping PR](https://github.com/shadps4-emu/shadPS4/pull/1356) that only contains the keyboard and mouse part, as this is already complete and has proven to be mostly bug-free, as it has been extensively tested by people using @diegolix29's fork. The controller part is still WIP and is not ready for merging yet, so until that's ready too, I'll just put this out here following @rainmakerv3's advice. The code still has some controller remapping elements left in, but they aren't hooked up to the main input loop. If I left in anything that I shouldn't have, please let me know. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>