[PR #1779] [MERGED] Fix update on windows when path contains powershell wildcards (#1391) #2297

New issue

Closed

opened 2026-02-27 21:15:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1779
Author: @alessandroampala
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/19/2024
Merged by: @georgemoralis

Base: main ← Head: update-fix-win

📝 Commits (2)

bf23a58 Fix update process on windows when there are some powershell wildcards in the installation path. (#1391)
14a7022 Fix coding style error. (#1391)

📊 Changes

1 file changed (+14 additions, -4 deletions)

View changed files

📝 src/qt_gui/check_update.cpp (+14 -4)

📄 Description

This pull request fixes issue #1391.
The problem was that some folder name characters (ie. '[') get recognized by some powershell commands as wildcards.

Now update gets downloaded (on windows) to AppData\Local\Temp
Start-Process powershell command escapes automatically wildcard characters

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1779 **Author:** [@alessandroampala](https://github.com/alessandroampala) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/19/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `update-fix-win` --- ### 📝 Commits (2) - [`bf23a58`](https://github.com/shadps4-emu/shadPS4/commit/bf23a58e3a98e4cd8690aa87c7eb63fef4e433f3) Fix update process on windows when there are some powershell wildcards in the installation path. (#1391) - [`14a7022`](https://github.com/shadps4-emu/shadPS4/commit/14a70222c43d2eae4c3172758704a0bc2930a824) Fix coding style error. (#1391) ### 📊 Changes **1 file changed** (+14 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/check_update.cpp` (+14 -4) </details> ### 📄 Description This pull request fixes issue #1391. The problem was that some folder name characters (ie. '[') get recognized by some powershell commands as wildcards. - Now update gets downloaded (on windows) to AppData\Local\Temp - Start-Process powershell command escapes automatically wildcard characters --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>