[PR #1769] [MERGED] Resize trophy pop up size based on window size #2290

New issue

Closed

opened 2026-02-27 21:15:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1769
Author: @rainmakerv3
Created: 12/14/2024
Status: ✅ Merged
Merged: 12/14/2024
Merged by: @georgemoralis

Base: main ← Head: trophypopupsize

📝 Commits (1)

752d910 Resize trophy pop up windows based on window size

📊 Changes

1 file changed (+7 additions, -5 deletions)

View changed files

📝 src/core/libraries/np_trophy/trophy_ui.cpp (+7 -5)

📄 Description

Right now the current trophy window is hardcoded to a certain size that seems to be optimized for 720:

Main 720p window:

It looks very small however at larger window sizes:

1440p window:

This PR adjusts the trophy window to be the same at any window size.

PR 720p window:

PR 1440p window:

I also increased the text size by 20% and lengthened the window to accommodate this, for better visibility. Also tested to work on fullscreen mode

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1769 **Author:** [@rainmakerv3](https://github.com/rainmakerv3) **Created:** 12/14/2024 **Status:** ✅ Merged **Merged:** 12/14/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `trophypopupsize` --- ### 📝 Commits (1) - [`752d910`](https://github.com/shadps4-emu/shadPS4/commit/752d910b49fefbf09be983770b3102912beda67d) Resize trophy pop up windows based on window size ### 📊 Changes **1 file changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/np_trophy/trophy_ui.cpp` (+7 -5) </details> ### 📄 Description Right now the current trophy window is hardcoded to a certain size that seems to be optimized for 720: Main 720p window: ![image](https://github.com/user-attachments/assets/11ecf5d6-4dd5-4fec-84a3-41d650bf1167) It looks very small however at larger window sizes: 1440p window: ![image](https://github.com/user-attachments/assets/82d3f79a-9fcc-4362-a3ec-025803416c81) This PR adjusts the trophy window to be the same at any window size. PR 720p window: ![image](https://github.com/user-attachments/assets/43412301-a011-4549-9afb-714dda44278e) PR 1440p window: ![image](https://github.com/user-attachments/assets/725689c5-d685-4e5c-a9d3-f10360a3cb38) I also increased the text size by 20% and lengthened the window to accommodate this, for better visibility. Also tested to work on fullscreen mode --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>