[PR #1688] [MERGED] fix: fix #1457 again by moving av_err2str to a common header #2246

New issue

Closed

opened 2026-02-27 21:15:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1688
Author: @neptuwunium
Created: 12/7/2024
Status: ✅ Merged
Merged: 12/7/2024
Merged by: @raphaelthegreat

Base: main ← Head: av_err2str-fix

📝 Commits (1)

4cef53e fix: fix #1457 again by moving av_err2str to a common header

📊 Changes

5 files changed (+22 additions, -30 deletions)

View changed files

➕ src/common/support/avdec.h (+17 -0)
📝 src/core/libraries/ajm/ajm_mp3.cpp (+2 -0)
📝 src/core/libraries/avplayer/avplayer_source.cpp (+1 -10)
📝 src/core/libraries/videodec/videodec2_impl.cpp (+1 -10)
📝 src/core/libraries/videodec/videodec_impl.cpp (+1 -10)

📄 Description

With the regression of #1457 happening a second time, I suggest moving the macro redefinition to a separate header so maintenance and remediation is easier to deal with as the macro will now exist in four distinct places.

Place relocate common/support/avdec.h if needed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1688 **Author:** [@neptuwunium](https://github.com/neptuwunium) **Created:** 12/7/2024 **Status:** ✅ Merged **Merged:** 12/7/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `av_err2str-fix` --- ### 📝 Commits (1) - [`4cef53e`](https://github.com/shadps4-emu/shadPS4/commit/4cef53e0ca9c6827a1a91aea21d4d239bdf80df8) fix: fix #1457 again by moving av_err2str to a common header ### 📊 Changes **5 files changed** (+22 additions, -30 deletions) <details> <summary>View changed files</summary> ➕ `src/common/support/avdec.h` (+17 -0) 📝 `src/core/libraries/ajm/ajm_mp3.cpp` (+2 -0) 📝 `src/core/libraries/avplayer/avplayer_source.cpp` (+1 -10) 📝 `src/core/libraries/videodec/videodec2_impl.cpp` (+1 -10) 📝 `src/core/libraries/videodec/videodec_impl.cpp` (+1 -10) </details> ### 📄 Description With the regression of #1457 happening a second time, I suggest moving the macro redefinition to a separate header so maintenance and remediation is easier to deal with as the macro will now exist in four distinct places. Place relocate `common/support/avdec.h` if needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>