[PR #1551] [MERGED] Fix build when -DENABLE_DISCORD_RPC=OFF #2166

New issue

Closed

opened 2026-02-27 21:15:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1551
Author: @aaalloc
Created: 11/19/2024
Status: ✅ Merged
Merged: 11/20/2024
Merged by: @georgemoralis

Base: main ← Head: fix-no-discordrpc-build

📝 Commits (2)

bcb8615 added ifdef for discordrpc
2cd3f02 replaced discordrpc include correctly

📊 Changes

4 files changed (+8 additions, -3 deletions)

View changed files

📝 src/common/discord_rpc_handler.cpp (+1 -1)
📝 src/qt_gui/main_window.cpp (+5 -1)
📝 src/qt_gui/main_window.h (+0 -1)
📝 src/qt_gui/settings_dialog.cpp (+2 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1551 **Author:** [@aaalloc](https://github.com/aaalloc) **Created:** 11/19/2024 **Status:** ✅ Merged **Merged:** 11/20/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `fix-no-discordrpc-build` --- ### 📝 Commits (2) - [`bcb8615`](https://github.com/shadps4-emu/shadPS4/commit/bcb861561b1af768dabd24643201ec95427a9eb9) added ifdef for discordrpc - [`2cd3f02`](https://github.com/shadps4-emu/shadPS4/commit/2cd3f02ddab36713893ca3950caa860d179ea4c9) replaced discordrpc include correctly ### 📊 Changes **4 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/common/discord_rpc_handler.cpp` (+1 -1) 📝 `src/qt_gui/main_window.cpp` (+5 -1) 📝 `src/qt_gui/main_window.h` (+0 -1) 📝 `src/qt_gui/settings_dialog.cpp` (+2 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>