[PR #1463] [MERGED] path_util: Make sure macOS has current directory set and clean up path code. #2122

New issue

Closed

opened 2026-02-27 21:15:17 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:17 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1463
Author: @squidbus
Created: 10/31/2024
Status: ✅ Merged
Merged: 10/31/2024
Merged by: @georgemoralis

Base: main ← Head: improve-paths

📝 Commits (1)

1077650 path_util: Make sure macOS has current directory set and clean up path code.

📊 Changes

1 file changed (+10 additions, -13 deletions)

View changed files

📝 src/common/path_util.cpp (+10 -13)

📄 Description

On macOS make sure that std::filesystem::current_path() is the directory containing the app bundle, similar to what it usually is on other platforms. This path is used by the updater, so this may fix issues with that on macOS.
Clean up user directory path resolution a bit to reuse code for the portable directory on all platforms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1463 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 10/31/2024 **Status:** ✅ Merged **Merged:** 10/31/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `improve-paths` --- ### 📝 Commits (1) - [`1077650`](https://github.com/shadps4-emu/shadPS4/commit/1077650bcac00356da46f6728fa6f3ceff0f17a3) path_util: Make sure macOS has current directory set and clean up path code. ### 📊 Changes **1 file changed** (+10 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `src/common/path_util.cpp` (+10 -13) </details> ### 📄 Description * On macOS make sure that `std::filesystem::current_path()` is the directory containing the app bundle, similar to what it usually is on other platforms. This path is used by the updater, so this may fix issues with that on macOS. * Clean up user directory path resolution a bit to reuse code for the portable directory on all platforms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>