[PR #302] [MERGED] Fixed buffer_store_* regression #1463

New issue

Closed

opened 2026-02-27 21:12:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/302
Author: @roamic
Created: 7/18/2024
Status: ✅ Merged
Merged: 7/18/2024
Merged by: @raphaelthegreat

Base: main ← Head: fix-buffer-store

📝 Commits (1)

ec1179b Fixed buffer_store_* regression

📊 Changes

1 file changed (+22 additions, -41 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp (+22 -41)

📄 Description

The logic of buffer address was changed in the previous commit to pass byte address.
buffer_load_* operations divide it by 4 to get dword index, while buffer_store_* operations were forgotten.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/302 **Author:** [@roamic](https://github.com/roamic) **Created:** 7/18/2024 **Status:** ✅ Merged **Merged:** 7/18/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix-buffer-store` --- ### 📝 Commits (1) - [`ec1179b`](https://github.com/shadps4-emu/shadPS4/commit/ec1179bf0d414d8932898f9e39767c4479fc1205) Fixed buffer_store_* regression ### 📊 Changes **1 file changed** (+22 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/emit_spirv_context_get_set.cpp` (+22 -41) </details> ### 📄 Description The logic of buffer address was changed in the previous commit to pass byte address. buffer_load_* operations divide it by 4 to get dword index, while buffer_store_* operations were forgotten. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>