[PR #1349] [CLOSED] Allowing Config class to resolve isFullscreen flag from CLI arguments #2064

New issue

Closed

opened 2026-02-27 21:15:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:15:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1349
Author: @robyn-dressler
Created: 10/12/2024
Status: ❌ Closed

Base: main ← Head: feature/fullscreen-flag

📝 Commits (8)

dbb0805 Allowing Config class to resolve isFullscreen flag from CLI arguments
c513073 Merge remote-tracking branch 'origin/main' into feature/fullscreen-flag
b1bbfa1 Formatting fix
c1ce5d7 Merge remote-tracking branch 'origin/main' into feature/fullscreen-flag
bf84589 Adding an alias for fullscreen flag, removing patchFile setting from toml file
7d40070 Fixing SDL build
df2f721 Formatting fix
99defa7 Rewriting code to use program_options library (pending ext-boost PR)

📊 Changes

6 files changed (+66 additions, -21 deletions)

View changed files

📝 CMakeLists.txt (+2 -2)
📝 src/common/config.cpp (+41 -0)
📝 src/common/config.h (+5 -0)
📝 src/emulator.cpp (+1 -1)
📝 src/main.cpp (+9 -9)
📝 src/qt_gui/main.cpp (+8 -9)

📄 Description

Addresses feature request #1147

Changes:

Move CLI argument parsing to Config class
Added -f and --fullscreen flags that override isFullscreen in the config
Added patchFile member variable to config (but excluding from TOML file, since it's game specific)
Added second overload to Emulator::Run

I have unfortunately not been able to properly test fullscreen in my environment due to #1348, but I think the new CLI argument works.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1349 **Author:** [@robyn-dressler](https://github.com/robyn-dressler) **Created:** 10/12/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `feature/fullscreen-flag` --- ### 📝 Commits (8) - [`dbb0805`](https://github.com/shadps4-emu/shadPS4/commit/dbb08050d42ea10d57dc22f9b92e870d703bbc7b) Allowing Config class to resolve isFullscreen flag from CLI arguments - [`c513073`](https://github.com/shadps4-emu/shadPS4/commit/c51307377f450a37515aa37a0d9ac92555ffde5b) Merge remote-tracking branch 'origin/main' into feature/fullscreen-flag - [`b1bbfa1`](https://github.com/shadps4-emu/shadPS4/commit/b1bbfa114653cc84b87dbec1ebe3806afe70f48a) Formatting fix - [`c1ce5d7`](https://github.com/shadps4-emu/shadPS4/commit/c1ce5d77808369ca88c2414da448ff089b4dd66f) Merge remote-tracking branch 'origin/main' into feature/fullscreen-flag - [`bf84589`](https://github.com/shadps4-emu/shadPS4/commit/bf84589d49dd4bf1fd37d2bbc2835be66262c2f3) Adding an alias for fullscreen flag, removing patchFile setting from toml file - [`7d40070`](https://github.com/shadps4-emu/shadPS4/commit/7d400703cfd33b5ed1a3dfee0d3d3d05ad9a78bd) Fixing SDL build - [`df2f721`](https://github.com/shadps4-emu/shadPS4/commit/df2f721449fe1d976a6cd6b9e4d825de19853a72) Formatting fix - [`99defa7`](https://github.com/shadps4-emu/shadPS4/commit/99defa7f08167799b9d66e7aca82e5e600060aa4) Rewriting code to use program_options library (pending ext-boost PR) ### 📊 Changes **6 files changed** (+66 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -2) 📝 `src/common/config.cpp` (+41 -0) 📝 `src/common/config.h` (+5 -0) 📝 `src/emulator.cpp` (+1 -1) 📝 `src/main.cpp` (+9 -9) 📝 `src/qt_gui/main.cpp` (+8 -9) </details> ### 📄 Description Addresses feature request #1147 Changes: - Move CLI argument parsing to `Config` class - Added `-f` and `--fullscreen` flags that override `isFullscreen` in the config - Added `patchFile` member variable to config (but excluding from TOML file, since it's game specific) - Added second overload to `Emulator::Run` I have unfortunately not been able to properly test fullscreen in my environment due to #1348, but I think the new CLI argument works. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>