[PR #1306] [MERGED] fix some warnings #2042

New issue

Closed

opened 2026-02-27 21:14:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1306
Author: @abouvier
Created: 10/9/2024
Status: ✅ Merged
Merged: 10/9/2024
Merged by: @raphaelthegreat

Base: main ← Head: fix-warnings

📝 Commits (1)

0854413 fix some warnings

📊 Changes

2 files changed (+8 additions, -5 deletions)

View changed files

📝 externals/CMakeLists.txt (+7 -4)
📝 src/imgui/imgui_config.h (+1 -1)

📄 Description

This warning was repeated many times:

[122/319] Building CXX object CMakeFiles/shadps4.dir/src/video_core/renderer_vulkan/vk_compute_pipeline.cpp.o
In file included from /build/shadps4-git/src/shadps4/externals/dear_imgui/imgui.h:64,
                 from /build/shadps4-git/src/shadps4/src/imgui/imgui_texture.h:7,
                 from /build/shadps4-git/src/shadps4/src/imgui/renderer/texture_manager.h:10,
                 from /build/shadps4-git/src/shadps4/src/video_core/renderer_vulkan/vk_scheduler.cpp:7:
/build/shadps4-git/src/shadps4/src/imgui/imgui_config.h:31:100: warning: backslash-newline at end of file
   31 | #define IM_VEC4_CLASS_EXTRA                                                                        \

Also disable warnings for every externals include directories.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1306 **Author:** [@abouvier](https://github.com/abouvier) **Created:** 10/9/2024 **Status:** ✅ Merged **Merged:** 10/9/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `fix-warnings` --- ### 📝 Commits (1) - [`0854413`](https://github.com/shadps4-emu/shadPS4/commit/0854413825033c0a82db23e4fa1eb04a25b00e2d) fix some warnings ### 📊 Changes **2 files changed** (+8 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `externals/CMakeLists.txt` (+7 -4) 📝 `src/imgui/imgui_config.h` (+1 -1) </details> ### 📄 Description This warning was repeated many times: ``` [122/319] Building CXX object CMakeFiles/shadps4.dir/src/video_core/renderer_vulkan/vk_compute_pipeline.cpp.o In file included from /build/shadps4-git/src/shadps4/externals/dear_imgui/imgui.h:64, from /build/shadps4-git/src/shadps4/src/imgui/imgui_texture.h:7, from /build/shadps4-git/src/shadps4/src/imgui/renderer/texture_manager.h:10, from /build/shadps4-git/src/shadps4/src/video_core/renderer_vulkan/vk_scheduler.cpp:7: /build/shadps4-git/src/shadps4/src/imgui/imgui_config.h:31:100: warning: backslash-newline at end of file 31 | #define IM_VEC4_CLASS_EXTRA \ ``` Also disable warnings for every externals include directories. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>