[PR #1267] [MERGED] ime_dialog: Initial implementation #2029

New issue

Closed

opened 2026-02-27 21:14:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1267
Author: @LNDF
Created: 10/6/2024
Status: ✅ Merged
Merged: 10/11/2024
Merged by: @georgemoralis

Base: main ← Head: ime

📝 Commits (10+)

8d930b4 Add C string types
5d1e11a Prepare existing enums
46a8ba9 Merge branch 'shadps4-emu:main' into ime
c392e73 Added missing enums
633f99e Merge branch 'ime' of https://github.com/LNDF/shadPS4 into ime
5e23306 Types update
cc784d9 State base
ca855e3 Compile Ime Dialog UI
b95576f UI implementation
cda002e Scoped lock

📊 Changes

7 files changed (+844 additions, -140 deletions)

View changed files

📝 CMakeLists.txt (+2 -0)
📝 src/common/cstring.h (+18 -4)
📝 src/core/libraries/dialogs/ime_dialog.cpp (+179 -28)
📝 src/core/libraries/dialogs/ime_dialog.h (+167 -107)
➕ src/core/libraries/dialogs/ime_dialog_ui.cpp (+390 -0)
➕ src/core/libraries/dialogs/ime_dialog_ui.h (+84 -0)
📝 src/imgui/imgui_config.h (+4 -1)

📄 Description

This PR adds a basic implementation of ime_dialog. Text can be entered using a ImGui windw opened on the screen when the game invokes que keyboard.

Supports both single line and multiline, numeric input and text filter callbacks.

I don't have access neither a macOS or Windows system so I was not able to thest it there.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1267 **Author:** [@LNDF](https://github.com/LNDF) **Created:** 10/6/2024 **Status:** ✅ Merged **Merged:** 10/11/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `ime` --- ### 📝 Commits (10+) - [`8d930b4`](https://github.com/shadps4-emu/shadPS4/commit/8d930b4e8837396f6a2710e2c8e07b726944631e) Add C string types - [`5d1e11a`](https://github.com/shadps4-emu/shadPS4/commit/5d1e11af85fb7b8b3d773e1d9e4867cd45c6c376) Prepare existing enums - [`46a8ba9`](https://github.com/shadps4-emu/shadPS4/commit/46a8ba91d554982b9c4bd92f0bfa7e552dde42ea) Merge branch 'shadps4-emu:main' into ime - [`c392e73`](https://github.com/shadps4-emu/shadPS4/commit/c392e7331c5194a3b66c4e4cfe7a4850c012f7f6) Added missing enums - [`633f99e`](https://github.com/shadps4-emu/shadPS4/commit/633f99e62adfe7d5415cf02d0427d2107a2bca11) Merge branch 'ime' of https://github.com/LNDF/shadPS4 into ime - [`5e23306`](https://github.com/shadps4-emu/shadPS4/commit/5e233069ffb0b4f1c23ae10e976751b4b65dc104) Types update - [`cc784d9`](https://github.com/shadps4-emu/shadPS4/commit/cc784d9f4779087cda97a41bda7311af76f5e4f6) State base - [`ca855e3`](https://github.com/shadps4-emu/shadPS4/commit/ca855e32953a550e61cd0e41cbc94e1376b6547c) Compile Ime Dialog UI - [`b95576f`](https://github.com/shadps4-emu/shadPS4/commit/b95576f6e303f7705e8c4b4888b5679bb643facd) UI implementation - [`cda002e`](https://github.com/shadps4-emu/shadPS4/commit/cda002e0fdcc42721de07e61571c9f5c2e8ca855) Scoped lock ### 📊 Changes **7 files changed** (+844 additions, -140 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -0) 📝 `src/common/cstring.h` (+18 -4) 📝 `src/core/libraries/dialogs/ime_dialog.cpp` (+179 -28) 📝 `src/core/libraries/dialogs/ime_dialog.h` (+167 -107) ➕ `src/core/libraries/dialogs/ime_dialog_ui.cpp` (+390 -0) ➕ `src/core/libraries/dialogs/ime_dialog_ui.h` (+84 -0) 📝 `src/imgui/imgui_config.h` (+4 -1) </details> ### 📄 Description This PR adds a basic implementation of ime_dialog. Text can be entered using a ImGui windw opened on the screen when the game invokes que keyboard. Supports both single line and multiline, numeric input and text filter callbacks. I don't have access neither a macOS or Windows system so I was not able to thest it there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>