[PR #1251] [MERGED] shader_recompiler: Set array size to max UBO size when 0. #2016

New issue

Closed

opened 2026-02-27 21:14:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1251
Author: @squidbus
Created: 10/5/2024
Status: ✅ Merged
Merged: 10/5/2024
Merged by: @georgemoralis

Base: main ← Head: valid-2

📝 Commits (2)

30c35e1 shader_recompiler: Set array size to max UBO size when 0.
eabc2e8 vulkan: Account for fallbacks when setting depth attachment format.

📊 Changes

3 files changed (+8 additions, -5 deletions)

View changed files

📝 src/shader_recompiler/backend/spirv/spirv_emit_context.cpp (+3 -3)
📝 src/shader_recompiler/info.h (+2 -1)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+3 -1)

📄 Description

Per comment on previous PR, change the array size 0 behavior to use maximum UBO size.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1251 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 10/5/2024 **Status:** ✅ Merged **Merged:** 10/5/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `valid-2` --- ### 📝 Commits (2) - [`30c35e1`](https://github.com/shadps4-emu/shadPS4/commit/30c35e1fe176c529a962ede5bab344c5576f77f7) shader_recompiler: Set array size to max UBO size when 0. - [`eabc2e8`](https://github.com/shadps4-emu/shadPS4/commit/eabc2e83c025d6b76ba297fe0a8ffc5cf640f20d) vulkan: Account for fallbacks when setting depth attachment format. ### 📊 Changes **3 files changed** (+8 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/backend/spirv/spirv_emit_context.cpp` (+3 -3) 📝 `src/shader_recompiler/info.h` (+2 -1) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+3 -1) </details> ### 📄 Description Per [comment on previous PR](https://github.com/shadps4-emu/shadPS4/pull/1250#issuecomment-2395153326), change the array size 0 behavior to use maximum UBO size. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>