[PR #1167] [CLOSED] Fix Discord RPC #1965

New issue

Closed

opened 2026-02-27 21:14:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1167
Author: @delledev
Created: 9/30/2024
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (2)

39b98fc fix discord rpc
3ac6320 code cleanup

📊 Changes

9 files changed (+53 additions, -16 deletions)

View changed files

📝 CMakeLists.txt (+8 -1)
📝 CMakeSettings.json (+0 -1)
📝 externals/CMakeLists.txt (+2 -1)
➕ externals/discord-rpc (+1 -0)
📝 src/common/discord.cpp (+24 -11)
📝 src/common/discord.h (+2 -1)
📝 src/emulator.cpp (+6 -0)
📝 src/qt_gui/main.cpp (+6 -0)
📝 src/sdl_window.cpp (+4 -1)

📄 Description

I was going to add Discord Rich Presence myself, but after digging around for a while I saw it was implemented a year ago. So I fixed it and it's now working.

This is my first time working with cpp and cmake so if i've done something wrong please let me know.

This is how it works currently.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1167 **Author:** [@delledev](https://github.com/delledev) **Created:** 9/30/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`39b98fc`](https://github.com/shadps4-emu/shadPS4/commit/39b98fcfdac9dade090060e6a4f1a9a1892511e5) fix discord rpc - [`3ac6320`](https://github.com/shadps4-emu/shadPS4/commit/3ac6320ec3f5d5a3f08560683838ca3964b4c3b3) code cleanup ### 📊 Changes **9 files changed** (+53 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+8 -1) 📝 `CMakeSettings.json` (+0 -1) 📝 `externals/CMakeLists.txt` (+2 -1) ➕ `externals/discord-rpc` (+1 -0) 📝 `src/common/discord.cpp` (+24 -11) 📝 `src/common/discord.h` (+2 -1) 📝 `src/emulator.cpp` (+6 -0) 📝 `src/qt_gui/main.cpp` (+6 -0) 📝 `src/sdl_window.cpp` (+4 -1) </details> ### 📄 Description I was going to add Discord Rich Presence myself, but after digging around for a while I saw it was implemented a year ago. So I fixed it and it's now working. This is my first time working with cpp and cmake so if i've done something wrong please let me know. This is how it works currently. ![img1](https://github.com/user-attachments/assets/92f6b380-8c49-40c8-bb18-1416e297095a) ![img0](https://github.com/user-attachments/assets/b57ebb26-dfe9-4d04-9b2b-81461e76e04d) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>