mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-25 07:46:01 +03:00
[PR #1033] [MERGED] Add playback of background/title music in game list #1894
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#1894
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/1033
Author: @tGecko
Created: 9/23/2024
Status: ✅ Merged
Merged: 9/26/2024
Merged by: @georgemoralis
Base:
main← Head:UI-title-music📝 Commits (10+)
217d221add playback of background/title music39d806bclang_format7907dd2add windows multimedia build instructions664541ffix typo accidentally made to arme2a5a0aaddress comments260a127loop music28f7371feedbackc45fe7dfix CI94e3c07add newlineaf26d22playBGM off by default📊 Changes
17 files changed (+181 additions, -17 deletions)
View changed files
📝
.github/workflows/build.yml(+3 -1)📝
CMakeLists.txt(+4 -2)📝
documents/building-windows.md(+2 -2)📝
src/common/config.cpp(+13 -1)📝
src/common/config.h(+2 -0)➕
src/qt_gui/background_music_player.cpp(+32 -0)➕
src/qt_gui/background_music_player.h(+28 -0)📝
src/qt_gui/game_grid_frame.cpp(+9 -0)📝
src/qt_gui/game_grid_frame.h(+2 -0)📝
src/qt_gui/game_info.h(+1 -0)📝
src/qt_gui/game_list_frame.cpp(+9 -0)📝
src/qt_gui/game_list_frame.h(+2 -0)📝
src/qt_gui/game_list_utils.h(+1 -0)📝
src/qt_gui/main_window.cpp(+20 -0)📝
src/qt_gui/main_window.h(+3 -0)📝
src/qt_gui/settings_dialog.cpp(+4 -1)📝
src/qt_gui/settings_dialog.ui(+46 -10)📄 Description
Upon selecting a game from game list/grid view, plays it's title music (
CUSAXXXXXX/sce_sys/snd0.at9) if available.Includes a setting to turn it on or off.
Special thanks to @cselip !
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.