[PR #1011] [MERGED] SaveLib PR related fixes #1879

New issue

Closed

opened 2026-02-27 21:14:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/1011
Author: @viniciuslrangel
Created: 9/21/2024
Status: ✅ Merged
Merged: 9/22/2024
Merged by: @georgemoralis

Base: main ← Head: savelib-fixes1

📝 Commits (3)

6c73d80 Safety checks in all SFO readings
a73efda SaveData: log backup error and continue & fix possible concurrent file editing
0ee1d37 SaveData: Fix issue with old firmwares

📊 Changes

11 files changed (+163 additions, -74 deletions)

View changed files

📝 src/core/libraries/app_content/app_content.cpp (+6 -1)
📝 src/core/libraries/save_data/dialog/savedatadialog_ui.cpp (+22 -15)
📝 src/core/libraries/save_data/dialog/savedatadialog_ui.h (+1 -0)
📝 src/core/libraries/save_data/save_backup.cpp (+24 -10)
📝 src/core/libraries/save_data/save_backup.h (+1 -0)
📝 src/core/libraries/save_data/savedata.cpp (+7 -5)
📝 src/emulator.cpp (+5 -3)
📝 src/qt_gui/game_info.h (+25 -10)
📝 src/qt_gui/gui_context_menus.h (+26 -14)
📝 src/qt_gui/main_window.cpp (+26 -6)
📝 src/qt_gui/pkg_viewer.cpp (+20 -10)

📄 Description

Fix SFO reading in QT, handling all cases when the key is not present
Avoid backup error crashing the world
Handle invalid param from old firmwares

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/1011 **Author:** [@viniciuslrangel](https://github.com/viniciuslrangel) **Created:** 9/21/2024 **Status:** ✅ Merged **Merged:** 9/22/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `savelib-fixes1` --- ### 📝 Commits (3) - [`6c73d80`](https://github.com/shadps4-emu/shadPS4/commit/6c73d8064157d475385fa8b2fe51931ed75fc70d) Safety checks in all SFO readings - [`a73efda`](https://github.com/shadps4-emu/shadPS4/commit/a73efdad300d97cee5f3c7eab9208e2c2cb88ffb) SaveData: log backup error and continue & fix possible concurrent file editing - [`0ee1d37`](https://github.com/shadps4-emu/shadPS4/commit/0ee1d37f0fd6c49ee7970e47910487913173f782) SaveData: Fix issue with old firmwares ### 📊 Changes **11 files changed** (+163 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/app_content/app_content.cpp` (+6 -1) 📝 `src/core/libraries/save_data/dialog/savedatadialog_ui.cpp` (+22 -15) 📝 `src/core/libraries/save_data/dialog/savedatadialog_ui.h` (+1 -0) 📝 `src/core/libraries/save_data/save_backup.cpp` (+24 -10) 📝 `src/core/libraries/save_data/save_backup.h` (+1 -0) 📝 `src/core/libraries/save_data/savedata.cpp` (+7 -5) 📝 `src/emulator.cpp` (+5 -3) 📝 `src/qt_gui/game_info.h` (+25 -10) 📝 `src/qt_gui/gui_context_menus.h` (+26 -14) 📝 `src/qt_gui/main_window.cpp` (+26 -6) 📝 `src/qt_gui/pkg_viewer.cpp` (+20 -10) </details> ### 📄 Description - Fix SFO reading in QT, handling all cases when the key is not present - Avoid backup error crashing the world - Handle invalid param from old firmwares --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>