[PR #959] [CLOSED] Use a singleton for instruction decoding #1851

New issue

Closed

opened 2026-02-27 21:14:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:14:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/959
Author: @OFFTKP
Created: 9/17/2024
Status: ❌ Closed

Base: main ← Head: decoder

📝 Commits (2)

6cc61fc Use a singleton for instruction decoding
1cd0616 Use singleton class

📊 Changes

5 files changed (+26 additions, -22 deletions)

View changed files

📝 CMakeLists.txt (+2 -2)
📝 src/common/decoder.cpp (+11 -6)
📝 src/common/decoder.h (+8 -3)
📝 src/core/cpu_patches.cpp (+3 -5)
📝 src/core/signals.cpp (+2 -6)

📄 Description

We're going to need the decoder in more places soon and don't need to do ZydisDecoderInit everywhere

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/959 **Author:** [@OFFTKP](https://github.com/OFFTKP) **Created:** 9/17/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `decoder` --- ### 📝 Commits (2) - [`6cc61fc`](https://github.com/shadps4-emu/shadPS4/commit/6cc61fc27df80aa28ed0a60b9fc1aa24b81846ad) Use a singleton for instruction decoding - [`1cd0616`](https://github.com/shadps4-emu/shadPS4/commit/1cd06161865c9bfaae702c25cd945416a1238b36) Use singleton class ### 📊 Changes **5 files changed** (+26 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -2) 📝 `src/common/decoder.cpp` (+11 -6) 📝 `src/common/decoder.h` (+8 -3) 📝 `src/core/cpu_patches.cpp` (+3 -5) 📝 `src/core/signals.cpp` (+2 -6) </details> ### 📄 Description We're going to need the decoder in more places soon and don't need to do ZydisDecoderInit everywhere --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>