[PR #773] [CLOSED] feat: General improvements for localizations #1764

New issue

Closed

opened 2026-02-27 21:13:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/773
Author: @mavethee
Created: 9/4/2024
Status: ❌ Closed

Base: main ← Head: missing_tr

📝 Commits (1)

84b92c7 feat: improve translations

📊 Changes

30 files changed (+32497 additions, -25595 deletions)

View changed files

📝 src/qt_gui/game_install_dialog.cpp (+8 -7)
📝 src/qt_gui/game_install_dialog.h (+7 -9)
📝 src/qt_gui/main_window.cpp (+63 -44)
📝 src/qt_gui/settings_dialog.cpp (+36 -33)
📝 src/qt_gui/translations/ar.ts (+1250 -985)
📝 src/qt_gui/translations/da_DK.ts (+1245 -978)
📝 src/qt_gui/translations/de.ts (+1245 -978)
📝 src/qt_gui/translations/el.ts (+1245 -978)
📝 src/qt_gui/translations/en.ts (+1245 -978)
📝 src/qt_gui/translations/es_ES.ts (+1245 -978)
📝 src/qt_gui/translations/fa_IR.ts (+1245 -978)
📝 src/qt_gui/translations/fi.ts (+1245 -978)
📝 src/qt_gui/translations/fr.ts (+0 -0)
📝 src/qt_gui/translations/hu_HU.ts (+0 -0)
📝 src/qt_gui/translations/id.ts (+0 -0)
📝 src/qt_gui/translations/it.ts (+0 -0)
📝 src/qt_gui/translations/ja_JP.ts (+0 -0)
📝 src/qt_gui/translations/ko_KR.ts (+0 -0)
📝 src/qt_gui/translations/lt_LT.ts (+0 -0)
📝 src/qt_gui/translations/nb.ts (+0 -0)

...and 10 more files

📄 Description

Details:

Running lupdate suggest some issues with headers but iirc there's nothing to translate there so I've skipped that.

/Users/marcinmitura/GitHub/shadPS4/src/common/logging/formatter.h:14: Ignoring definition of undeclared qualified class
/Users/marcinmitura/GitHub/shadPS4/src/common/slot_vector.h:164: Ignoring definition of undeclared qualified class
/Users/marcinmitura/GitHub/shadPS4/src/video_core/amdgpu/pixel_format.h:79: Ignoring definition of undeclared qualified class
/Users/marcinmitura/GitHub/shadPS4/src/video_core/amdgpu/pixel_format.h:89: Ignoring definition of undeclared qualified class
/Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/reg.h:482: Ignoring definition of undeclared qualified class
/Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/reg.h:491: Ignoring definition of undeclared qualified class
/Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/attribute.h:104: Ignoring definition of undeclared qualified class
/Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/type.h:49: Ignoring definition of undeclared qualified class
/Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/opcodes.h:99: Ignoring definition of undeclared qualified class
/Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/info.h:224: Ignoring definition of undeclared qualified class
/Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/condition.h:46: Ignoring definition of undeclared qualified class

As I only know polish, rest is left blank for translators.

What has been done?

Translations:
- Fixed game_install_dialog.cpp, which was lacking Q_OBJECT macro.
- Trivial dialog options like yes or no etc. were translated.
- Fix lupdate breaking formatting and removing copyright.
Improvements:
- shadPS4 is able to tell the difference between successfully installed game and DLC.

TODO:

Find myself, I'm not able to tell what my goal was.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/773 **Author:** [@mavethee](https://github.com/mavethee) **Created:** 9/4/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `missing_tr` --- ### 📝 Commits (1) - [`84b92c7`](https://github.com/shadps4-emu/shadPS4/commit/84b92c732e754d60f20b42bc109ca4efce03450f) feat: improve translations ### 📊 Changes **30 files changed** (+32497 additions, -25595 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/game_install_dialog.cpp` (+8 -7) 📝 `src/qt_gui/game_install_dialog.h` (+7 -9) 📝 `src/qt_gui/main_window.cpp` (+63 -44) 📝 `src/qt_gui/settings_dialog.cpp` (+36 -33) 📝 `src/qt_gui/translations/ar.ts` (+1250 -985) 📝 `src/qt_gui/translations/da_DK.ts` (+1245 -978) 📝 `src/qt_gui/translations/de.ts` (+1245 -978) 📝 `src/qt_gui/translations/el.ts` (+1245 -978) 📝 `src/qt_gui/translations/en.ts` (+1245 -978) 📝 `src/qt_gui/translations/es_ES.ts` (+1245 -978) 📝 `src/qt_gui/translations/fa_IR.ts` (+1245 -978) 📝 `src/qt_gui/translations/fi.ts` (+1245 -978) 📝 `src/qt_gui/translations/fr.ts` (+0 -0) 📝 `src/qt_gui/translations/hu_HU.ts` (+0 -0) 📝 `src/qt_gui/translations/id.ts` (+0 -0) 📝 `src/qt_gui/translations/it.ts` (+0 -0) 📝 `src/qt_gui/translations/ja_JP.ts` (+0 -0) 📝 `src/qt_gui/translations/ko_KR.ts` (+0 -0) 📝 `src/qt_gui/translations/lt_LT.ts` (+0 -0) 📝 `src/qt_gui/translations/nb.ts` (+0 -0) _...and 10 more files_ </details> ### 📄 Description ## Details: Running `lupdate` suggest some issues with headers but iirc there's nothing to translate there so I've skipped that. <details> ```sh /Users/marcinmitura/GitHub/shadPS4/src/common/logging/formatter.h:14: Ignoring definition of undeclared qualified class /Users/marcinmitura/GitHub/shadPS4/src/common/slot_vector.h:164: Ignoring definition of undeclared qualified class /Users/marcinmitura/GitHub/shadPS4/src/video_core/amdgpu/pixel_format.h:79: Ignoring definition of undeclared qualified class /Users/marcinmitura/GitHub/shadPS4/src/video_core/amdgpu/pixel_format.h:89: Ignoring definition of undeclared qualified class /Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/reg.h:482: Ignoring definition of undeclared qualified class /Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/reg.h:491: Ignoring definition of undeclared qualified class /Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/attribute.h:104: Ignoring definition of undeclared qualified class /Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/type.h:49: Ignoring definition of undeclared qualified class /Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/opcodes.h:99: Ignoring definition of undeclared qualified class /Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/info.h:224: Ignoring definition of undeclared qualified class /Users/marcinmitura/GitHub/shadPS4/src/shader_recompiler/ir/condition.h:46: Ignoring definition of undeclared qualified class ``` </details> _**As I only know polish, rest is left blank for translators.**_ ## What has been done? - [x] Translations: - [x] Fixed `game_install_dialog.cpp`, which was lacking `Q_OBJECT` macro. - [x] Trivial dialog options like yes or no etc. were translated. - [ ] Fix `lupdate` breaking formatting and removing copyright. - [x] Improvements: - [x] shadPS4 is able to tell the difference between successfully installed game and DLC. ## TODO: - [ ] Find myself, I'm not able to tell what my goal was. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>