[PR #753] [MERGED] vulkan: Improve format support info for vertex buffer formats. #1751

New issue

Closed

opened 2026-02-27 21:13:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/753
Author: @squidbus
Created: 9/3/2024
Status: ✅ Merged
Merged: 9/3/2024
Merged by: @raphaelthegreat

Base: main ← Head: format-info

📝 Commits (1)

964ec43 vulkan: Improve format support info for vertex buffer formats.

📊 Changes

2 files changed (+30 additions, -9 deletions)

View changed files

📝 src/video_core/renderer_vulkan/vk_instance.cpp (+25 -7)
📝 src/video_core/renderer_vulkan/vk_instance.h (+5 -2)

📄 Description

Slightly improves printing of format support info by noting if a format is supported for vertex buffers, if not supported for images.

Ideally we would be able to report based on what these formats may actually be used for in practice but that does not seem to be well tracked; currently everything is bucketed into SurfaceFormat. This is the next best thing I could come up with to note that, while a format may not be supported for images, it is supported for vertex buffers and thus that may not be an issue.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/753 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 9/3/2024 **Status:** ✅ Merged **Merged:** 9/3/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `format-info` --- ### 📝 Commits (1) - [`964ec43`](https://github.com/shadps4-emu/shadPS4/commit/964ec43c280dc51cc0a18f313375df8cc3d15bde) vulkan: Improve format support info for vertex buffer formats. ### 📊 Changes **2 files changed** (+30 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+25 -7) 📝 `src/video_core/renderer_vulkan/vk_instance.h` (+5 -2) </details> ### 📄 Description Slightly improves printing of format support info by noting if a format is supported for vertex buffers, if not supported for images. Ideally we would be able to report based on what these formats may actually be used for in practice but that does not seem to be well tracked; currently everything is bucketed into `SurfaceFormat`. This is the next best thing I could come up with to note that, while a format may not be supported for images, it is supported for vertex buffers and thus that may not be an issue. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>