[PR #670] [MERGED] vulkan: Few fixes for MoltenVK #1704

New issue

Closed

opened 2026-02-27 21:13:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:13:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/670
Author: @squidbus
Created: 8/30/2024
Status: ✅ Merged
Merged: 8/30/2024
Merged by: @raphaelthegreat

Base: main ← Head: vk-fixes

📝 Commits (2)

aea633d vulkan: Use SPIR-V 1.5 when Vulkan version is 1.2
bfb6870 vulkan: Fix Format2_10_10_10 mismap

📊 Changes

2 files changed (+6 additions, -10 deletions)

View changed files

📝 src/video_core/renderer_vulkan/liverpool_to_vk.cpp (+5 -9)
📝 src/video_core/renderer_vulkan/vk_shader_cache.cpp (+1 -1)

📄 Description

Fix an apparent mis-map of Format2_10_10_10. The Unorm version would map to A2B10G10R10UnormPack32 with an unused duplicate mapping to A2R10G10B10UnormPack32, and the Snorm version would map to A2R10G10B10SnormPack32. Now both only map to their respective A2B10G10R10 formats. This helps for games that use these formats under MoltenVK since it does not support the A2R10G10B10 versions for vertex buffers.
Set SPIR-V version to 1.5 if not using Vulkan 1.3 to silence a validation error about supported versions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/670 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 8/30/2024 **Status:** ✅ Merged **Merged:** 8/30/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `vk-fixes` --- ### 📝 Commits (2) - [`aea633d`](https://github.com/shadps4-emu/shadPS4/commit/aea633d63cc1abee43f6ecff197359fba8246552) vulkan: Use SPIR-V 1.5 when Vulkan version is 1.2 - [`bfb6870`](https://github.com/shadps4-emu/shadPS4/commit/bfb68704ce85bcb65c7a0c29eaa26cab26bdb22b) vulkan: Fix Format2_10_10_10 mismap ### 📊 Changes **2 files changed** (+6 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.cpp` (+5 -9) 📝 `src/video_core/renderer_vulkan/vk_shader_cache.cpp` (+1 -1) </details> ### 📄 Description * Fix an apparent mis-map of Format2_10_10_10. The Unorm version would map to `A2B10G10R10UnormPack32` with an unused duplicate mapping to `A2R10G10B10UnormPack32`, and the Snorm version would map to `A2R10G10B10SnormPack32`. Now both only map to their respective A2B10G10R10 formats. This helps for games that use these formats under MoltenVK since it does not support the A2R10G10B10 versions for vertex buffers. * Set SPIR-V version to 1.5 if not using Vulkan 1.3 to silence a validation error about supported versions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>