[PR #392] [CLOSED] qt_gui: Added stopping games by escape key or stop button #1538

Closed
opened 2026-02-27 21:12:59 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/392
Author: @ElBread3
Created: 8/9/2024
Status: Closed

Base: mainHead: stopgamesesc


📝 Commits (3)

  • 2c5264b stop games with esc key or stop button
  • c830d79 Merge branch 'main' into stopgamesesc
  • e92aaad Merge branch 'main' into stopgamesesc

📊 Changes

6 files changed (+46 additions, -0 deletions)

View changed files

📝 CMakeLists.txt (+6 -0)
📝 src/qt_gui/main_window.cpp (+7 -0)
📝 src/qt_gui/main_window.h (+1 -0)
📝 src/sdl_window.cpp (+6 -0)
src/sdl_window_manager.cpp (+16 -0)
src/sdl_window_manager.h (+10 -0)

📄 Description

This PR should theoretically add stopping games by either pressing escape or the stop button in the main window. This is implemented by creating a SDL window manager that's only current use is to hold a function that simply sends a quit event in order to close the window (less invasive than adding SDL headers into QT classes, also can be expanded in the future). It is important to note that currently the emulator doesn't seem to have any de-initialization functions which would need to be implemented so that exiting isn't basically a crash.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/392 **Author:** [@ElBread3](https://github.com/ElBread3) **Created:** 8/9/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `stopgamesesc` --- ### 📝 Commits (3) - [`2c5264b`](https://github.com/shadps4-emu/shadPS4/commit/2c5264b92756b121d92a7d91015e9c36a6a2e7d6) stop games with esc key or stop button - [`c830d79`](https://github.com/shadps4-emu/shadPS4/commit/c830d7920dcae891075ac96eea470c597a6b50af) Merge branch 'main' into stopgamesesc - [`e92aaad`](https://github.com/shadps4-emu/shadPS4/commit/e92aaadac3a98cddfb7747775611e530371d03df) Merge branch 'main' into stopgamesesc ### 📊 Changes **6 files changed** (+46 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+6 -0) 📝 `src/qt_gui/main_window.cpp` (+7 -0) 📝 `src/qt_gui/main_window.h` (+1 -0) 📝 `src/sdl_window.cpp` (+6 -0) ➕ `src/sdl_window_manager.cpp` (+16 -0) ➕ `src/sdl_window_manager.h` (+10 -0) </details> ### 📄 Description This PR should theoretically add stopping games by either pressing escape or the stop button in the main window. This is implemented by creating a SDL window manager that's only current use is to hold a function that simply sends a quit event in order to close the window (less invasive than adding SDL headers into QT classes, also can be expanded in the future). It is important to note that currently the emulator doesn't seem to have any de-initialization functions which would need to be implemented so that exiting isn't basically a crash. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 21:12:59 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/shadPS4#1538
No description provided.