mirror of
https://github.com/shadps4-emu/shadPS4.git
synced 2026-04-26 08:15:59 +03:00
[PR #392] [CLOSED] qt_gui: Added stopping games by escape key or stop button #1538
Labels
No labels
Bloodborne
bug
contributor wanted
documentation
enhancement
frontend
good first issue
help wanted
linux
pull-request
question
release
verification progress
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/shadPS4#1538
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/shadps4-emu/shadPS4/pull/392
Author: @ElBread3
Created: 8/9/2024
Status: ❌ Closed
Base:
main← Head:stopgamesesc📝 Commits (3)
2c5264bstop games with esc key or stop buttonc830d79Merge branch 'main' into stopgamesesce92aaadMerge branch 'main' into stopgamesesc📊 Changes
6 files changed (+46 additions, -0 deletions)
View changed files
📝
CMakeLists.txt(+6 -0)📝
src/qt_gui/main_window.cpp(+7 -0)📝
src/qt_gui/main_window.h(+1 -0)📝
src/sdl_window.cpp(+6 -0)➕
src/sdl_window_manager.cpp(+16 -0)➕
src/sdl_window_manager.h(+10 -0)📄 Description
This PR should theoretically add stopping games by either pressing escape or the stop button in the main window. This is implemented by creating a SDL window manager that's only current use is to hold a function that simply sends a quit event in order to close the window (less invasive than adding SDL headers into QT classes, also can be expanded in the future). It is important to note that currently the emulator doesn't seem to have any de-initialization functions which would need to be implemented so that exiting isn't basically a crash.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.