[PR #383] [CLOSED] qt_gui: Added stopping games by esc or stop button #1528

New issue

Closed

opened 2026-02-27 21:12:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/383
Author: @ElBread3
Created: 8/8/2024
Status: ❌ Closed

Base: main ← Head: stop-button

📝 Commits (2)

71fefbf add stopping games by esc or main window
1e0f6c9 Merge branch 'shadps4-emu:main' into stop-button

📊 Changes

6 files changed (+42 additions, -0 deletions)

View changed files

📝 CMakeLists.txt (+2 -0)
📝 src/qt_gui/main_window.cpp (+7 -0)
📝 src/qt_gui/main_window.h (+1 -0)
📝 src/sdl_window.cpp (+6 -0)
➕ src/sdl_window_manager.cpp (+16 -0)
➕ src/sdl_window_manager.h (+10 -0)

📄 Description

This PR should theoretically add stopping games by either pressing escape or the stop button in the main window. This is implemented by creating a SDL window manager that's only current use is to hold a function that simply sends a quit event in order to close the window (less invasive than adding SDL headers into QT classes, also can be expanded in the future).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/383 **Author:** [@ElBread3](https://github.com/ElBread3) **Created:** 8/8/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `stop-button` --- ### 📝 Commits (2) - [`71fefbf`](https://github.com/shadps4-emu/shadPS4/commit/71fefbf596e21615100535bc84cf8da649473f56) add stopping games by esc or main window - [`1e0f6c9`](https://github.com/shadps4-emu/shadPS4/commit/1e0f6c93939b7a6ba4a51e48090138d7acc4c6c9) Merge branch 'shadps4-emu:main' into stop-button ### 📊 Changes **6 files changed** (+42 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CMakeLists.txt` (+2 -0) 📝 `src/qt_gui/main_window.cpp` (+7 -0) 📝 `src/qt_gui/main_window.h` (+1 -0) 📝 `src/sdl_window.cpp` (+6 -0) ➕ `src/sdl_window_manager.cpp` (+16 -0) ➕ `src/sdl_window_manager.h` (+10 -0) </details> ### 📄 Description This PR should theoretically add stopping games by either pressing escape or the stop button in the main window. This is implemented by creating a SDL window manager that's only current use is to hold a function that simply sends a quit event in order to close the window (less invasive than adding SDL headers into QT classes, also can be expanded in the future). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>