[PR #314] [MERGED] Replace remaining uses of `QDir::currentPath() / "user"` with `GetUserPath(UserDir)`. #1472

New issue

Closed

opened 2026-02-27 21:12:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/314
Author: @squidbus
Created: 7/21/2024
Status: ✅ Merged
Merged: 7/22/2024
Merged by: @georgemoralis

Base: main ← Head: game-data-path

📝 Commits (1)

54b5900 Replace remaining uses of QDir::currentPath() / user with UserDir.

📊 Changes

3 files changed (+36 additions, -17 deletions)

View changed files

📝 src/qt_gui/game_grid_frame.cpp (+11 -7)
📝 src/qt_gui/game_list_frame.cpp (+12 -7)
📝 src/qt_gui/trophy_viewer.cpp (+13 -3)

📄 Description

Instead of relying on QDir::currentPath() + "/user" to be correct, use GetUserPath(UserDir) as the single source of truth on the user directory like the rest of the codebase.

I think I handled the cases where wstring is needed for Windows correctly, let me know if there's anything wrong there.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/314 **Author:** [@squidbus](https://github.com/squidbus) **Created:** 7/21/2024 **Status:** ✅ Merged **Merged:** 7/22/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `game-data-path` --- ### 📝 Commits (1) - [`54b5900`](https://github.com/shadps4-emu/shadPS4/commit/54b59004986ee5e054ea4381b1829b5fca7eef16) Replace remaining uses of QDir::currentPath() / user with UserDir. ### 📊 Changes **3 files changed** (+36 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/qt_gui/game_grid_frame.cpp` (+11 -7) 📝 `src/qt_gui/game_list_frame.cpp` (+12 -7) 📝 `src/qt_gui/trophy_viewer.cpp` (+13 -3) </details> ### 📄 Description Instead of relying on `QDir::currentPath() + "/user"` to be correct, use `GetUserPath(UserDir)` as the single source of truth on the user directory like the rest of the codebase. I think I handled the cases where `wstring` is needed for Windows correctly, let me know if there's anything wrong there. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>