[PR #288] [CLOSED] Removing unused .DLL #1452

New issue

Closed

opened 2026-02-27 21:12:36 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/288
Author: @Xphalnos
Created: 7/12/2024
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (5)

8162016 Removing unused .DLL
33a6ab9 Update submodules
5b9b47b Update CMakeLists.txt
6297faa Update CMakeLists.txt
bbab7fe Update CMakeLists.txt

📊 Changes

6 files changed (+13 additions, -21 deletions)

View changed files

📝 .github/workflows/windows-qt.yml (+2 -1)
📝 CMakeLists.txt (+7 -16)
📝 externals/glslang (+1 -1)
📝 externals/magic_enum (+1 -1)
📝 externals/vulkan-headers (+1 -1)
📝 externals/zydis (+1 -1)

📄 Description

I finished the cleanup of CMakeLists.txt by deleting what I had forgotten to delete.
I modified the Windows-Qt workflow to not download unnecessary .DLL files.
This reduces the size of the artifacts by almost 10MB.
This also reduces compilation time.
I took the opportunity to update the submodules.
Tested and working!

Before:

After:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/288 **Author:** [@Xphalnos](https://github.com/Xphalnos) **Created:** 7/12/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`8162016`](https://github.com/shadps4-emu/shadPS4/commit/81620169b6e3195e7d3780a8c8aec04e196cb886) Removing unused .DLL - [`33a6ab9`](https://github.com/shadps4-emu/shadPS4/commit/33a6ab959fa6bb164dff47967a65f0bea7427470) Update submodules - [`5b9b47b`](https://github.com/shadps4-emu/shadPS4/commit/5b9b47b976fc3526517ca4b12e1f8843c272954e) Update CMakeLists.txt - [`6297faa`](https://github.com/shadps4-emu/shadPS4/commit/6297faae23ca81e52e2236e3e9da5271b4fed7e6) Update CMakeLists.txt - [`bbab7fe`](https://github.com/shadps4-emu/shadPS4/commit/bbab7fe56e538c705bf780a31f034595045863a1) Update CMakeLists.txt ### 📊 Changes **6 files changed** (+13 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/windows-qt.yml` (+2 -1) 📝 `CMakeLists.txt` (+7 -16) 📝 `externals/glslang` (+1 -1) 📝 `externals/magic_enum` (+1 -1) 📝 `externals/vulkan-headers` (+1 -1) 📝 `externals/zydis` (+1 -1) </details> ### 📄 Description I finished the cleanup of CMakeLists.txt by deleting what I had forgotten to delete. I modified the Windows-Qt workflow to not download unnecessary .DLL files. This reduces the size of the artifacts by almost 10MB. This also reduces compilation time. I took the opportunity to update the submodules. Tested and working! Before: ![image](https://github.com/user-attachments/assets/b76a1f73-d2c7-4f7e-9180-1c398754c70d) After: ![Capture d'écran 2024-07-12 133613](https://github.com/user-attachments/assets/3043f475-50b9-4634-b82c-ae6cfba00069) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>