[PR #223] [MERGED] Metadata support #1406

New issue

Closed

opened 2026-02-27 21:12:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/223
Author: @psucien
Created: 6/29/2024
Status: ✅ Merged
Merged: 6/29/2024
Merged by: @raphaelthegreat

Base: main ← Head: amdgpu/meta

📝 Commits (8)

9f600df texture_cache: more image usage flags
ac6a60d texture_cache: metadata registration
2b59838 renderer_vulkan: initial CMask support
9982f1b renderer_vulkan: skip redundant FCE and FMask decompression passes
5b909c6 renderer_vulkan: redundant VO surface registration removed
ff9850c renderer_vulkan: initial HTile support
a05d006 renderer_vulkan: added support for MSAA attachments
cfdfda9 renderer_vulkan: skip unnecessary metadata updates

📊 Changes

16 files changed (+336 additions, -47 deletions)

View changed files

📝 src/shader_recompiler/ir/passes/resource_tracking_pass.cpp (+10 -6)
📝 src/video_core/amdgpu/liverpool.h (+47 -8)
📝 src/video_core/renderer_vulkan/liverpool_to_vk.cpp (+73 -0)
📝 src/video_core/renderer_vulkan/liverpool_to_vk.h (+4 -0)
📝 src/video_core/renderer_vulkan/renderer_vulkan.h (+2 -1)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.cpp (+29 -9)
📝 src/video_core/renderer_vulkan/vk_compute_pipeline.h (+1 -1)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp (+11 -2)
📝 src/video_core/renderer_vulkan/vk_graphics_pipeline.h (+1 -0)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+1 -0)
📝 src/video_core/renderer_vulkan/vk_pipeline_cache.cpp (+20 -1)
📝 src/video_core/renderer_vulkan/vk_rasterizer.cpp (+25 -6)
📝 src/video_core/texture_cache/image.cpp (+7 -2)
📝 src/video_core/texture_cache/image.h (+14 -8)
📝 src/video_core/texture_cache/texture_cache.cpp (+54 -3)
📝 src/video_core/texture_cache/texture_cache.h (+37 -0)

📄 Description

Added support for color and depth surfaces clears based on tracking of metadata updates. Does not cover DCC yet (mostly Pro cases).
Removed redundant dispatches and draws, assuming we deal only with metadata clears.
Left log messages in case if metadata is read.

Additional features and fixes:

Added support for MSAA render targets.
Fixed a memory leak on VO surfaces registration
Better image usage tracking

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/223 **Author:** [@psucien](https://github.com/psucien) **Created:** 6/29/2024 **Status:** ✅ Merged **Merged:** 6/29/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `amdgpu/meta` --- ### 📝 Commits (8) - [`9f600df`](https://github.com/shadps4-emu/shadPS4/commit/9f600dfab3751747e1e467730327f09e8ab1089a) texture_cache: more image usage flags - [`ac6a60d`](https://github.com/shadps4-emu/shadPS4/commit/ac6a60d80910089c3b25b2b445b631aa3ebc5b3b) texture_cache: metadata registration - [`2b59838`](https://github.com/shadps4-emu/shadPS4/commit/2b5983844d7d4426e15b18e45915978a3ee9b965) renderer_vulkan: initial CMask support - [`9982f1b`](https://github.com/shadps4-emu/shadPS4/commit/9982f1be6f11c6d341197487867239b822e91350) renderer_vulkan: skip redundant FCE and FMask decompression passes - [`5b909c6`](https://github.com/shadps4-emu/shadPS4/commit/5b909c659d59775a954f3ae7e66a69d24afde7fe) renderer_vulkan: redundant VO surface registration removed - [`ff9850c`](https://github.com/shadps4-emu/shadPS4/commit/ff9850ca00ab0c785baa4be8018fd2e08155f70d) renderer_vulkan: initial HTile support - [`a05d006`](https://github.com/shadps4-emu/shadPS4/commit/a05d0063fc5f9232008bcde7ad214df628cd4e72) renderer_vulkan: added support for MSAA attachments - [`cfdfda9`](https://github.com/shadps4-emu/shadPS4/commit/cfdfda97a2434717579181b0baa73d75e945a48d) renderer_vulkan: skip unnecessary metadata updates ### 📊 Changes **16 files changed** (+336 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `src/shader_recompiler/ir/passes/resource_tracking_pass.cpp` (+10 -6) 📝 `src/video_core/amdgpu/liverpool.h` (+47 -8) 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.cpp` (+73 -0) 📝 `src/video_core/renderer_vulkan/liverpool_to_vk.h` (+4 -0) 📝 `src/video_core/renderer_vulkan/renderer_vulkan.h` (+2 -1) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.cpp` (+29 -9) 📝 `src/video_core/renderer_vulkan/vk_compute_pipeline.h` (+1 -1) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.cpp` (+11 -2) 📝 `src/video_core/renderer_vulkan/vk_graphics_pipeline.h` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+1 -0) 📝 `src/video_core/renderer_vulkan/vk_pipeline_cache.cpp` (+20 -1) 📝 `src/video_core/renderer_vulkan/vk_rasterizer.cpp` (+25 -6) 📝 `src/video_core/texture_cache/image.cpp` (+7 -2) 📝 `src/video_core/texture_cache/image.h` (+14 -8) 📝 `src/video_core/texture_cache/texture_cache.cpp` (+54 -3) 📝 `src/video_core/texture_cache/texture_cache.h` (+37 -0) </details> ### 📄 Description - Added support for color and depth surfaces clears based on tracking of metadata updates. Does not cover DCC yet (mostly Pro cases). - Removed redundant dispatches and draws, assuming we deal only with metadata clears. - Left log messages in case if metadata is read. Additional features and fixes: - Added support for MSAA render targets. - Fixed a memory leak on VO surfaces registration - Better image usage tracking --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>