[PR #216] [MERGED] cmake: prefer system libraries #1401

New issue

Closed

opened 2026-02-27 21:12:23 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/216
Author: @abouvier
Created: 6/26/2024
Status: ✅ Merged
Merged: 6/27/2024
Merged by: @raphaelthegreat

Base: main ← Head: cmake-unbundle

📝 Commits (1)

d0f0f5a cmake: prefer system libraries

📊 Changes

8 files changed (+147 additions, -65 deletions)

View changed files

📝 .github/workflows/linux.yml (+0 -1)
📝 .github/workflows/windows-qt.yml (+0 -2)
📝 .github/workflows/windows.yml (+0 -1)
📝 CMakeLists.txt (+22 -15)
➕ cmake/Findcryptopp.cmake (+15 -0)
➕ cmake/FindxxHash.cmake (+15 -0)
➕ cmake/Findzlib-ng.cmake (+15 -0)
📝 externals/CMakeLists.txt (+80 -46)

📄 Description

Is there a reason why sdl3 and zlib-ng were compiled as shared libraries?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/216 **Author:** [@abouvier](https://github.com/abouvier) **Created:** 6/26/2024 **Status:** ✅ Merged **Merged:** 6/27/2024 **Merged by:** [@raphaelthegreat](https://github.com/raphaelthegreat) **Base:** `main` ← **Head:** `cmake-unbundle` --- ### 📝 Commits (1) - [`d0f0f5a`](https://github.com/shadps4-emu/shadPS4/commit/d0f0f5a16abf2cffdd9a90b24374156ee74c103d) cmake: prefer system libraries ### 📊 Changes **8 files changed** (+147 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/linux.yml` (+0 -1) 📝 `.github/workflows/windows-qt.yml` (+0 -2) 📝 `.github/workflows/windows.yml` (+0 -1) 📝 `CMakeLists.txt` (+22 -15) ➕ `cmake/Findcryptopp.cmake` (+15 -0) ➕ `cmake/FindxxHash.cmake` (+15 -0) ➕ `cmake/Findzlib-ng.cmake` (+15 -0) 📝 `externals/CMakeLists.txt` (+80 -46) </details> ### 📄 Description Is there a reason why `sdl3` and `zlib-ng` were compiled as shared libraries? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>