[PR #150] [MERGED] video_core: various fixes #1341

New issue

Closed

opened 2026-02-27 21:12:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 21:12:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/shadps4-emu/shadPS4/pull/150
Author: @psucien
Created: 5/29/2024
Status: ✅ Merged
Merged: 5/29/2024
Merged by: @georgemoralis

Base: main ← Head: stabilization_one

📝 Commits (7)

fb237bd libraries: libc: fix for FSin implementation
e5486cc video_core: amdgpu: proper destruction of processing thread
db113bb videoout, platform: fix for ooo irqs
5f37a6b video_core: amdgpu: fix for a deadlock in wait on idle
a67b8f7 video_core: renderer_vulkan: proper inclusion of maintenance4
055dec1 video_core: texture_cache: proper UniqueImage class movers
7fc273c clang fmt

📊 Changes

9 files changed (+31 additions, -30 deletions)

View changed files

📝 src/core/libraries/libc/libc_math.cpp (+8 -2)
📝 src/core/libraries/libc/libc_math.h (+1 -1)
📝 src/core/libraries/videoout/driver.h (+1 -1)
📝 src/core/libraries/videoout/video_out.cpp (+1 -0)
📝 src/core/platform.h (+1 -1)
📝 src/video_core/amdgpu/liverpool.cpp (+12 -18)
📝 src/video_core/amdgpu/liverpool.h (+0 -3)
📝 src/video_core/renderer_vulkan/vk_instance.cpp (+1 -3)
📝 src/video_core/texture_cache/image.h (+6 -1)

📄 Description

This PR addresses the next issues:

out of order flip IRQ processing;
incorrect renderer de-initialization;
possible deadlock in gpu idle waits;
incorrect _Fsin implementation in HLE libc

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/shadps4-emu/shadPS4/pull/150 **Author:** [@psucien](https://github.com/psucien) **Created:** 5/29/2024 **Status:** ✅ Merged **Merged:** 5/29/2024 **Merged by:** [@georgemoralis](https://github.com/georgemoralis) **Base:** `main` ← **Head:** `stabilization_one` --- ### 📝 Commits (7) - [`fb237bd`](https://github.com/shadps4-emu/shadPS4/commit/fb237bddadb937ded6fd7bfb0f5bb9e061fdaaa2) libraries: libc: fix for `FSin` implementation - [`e5486cc`](https://github.com/shadps4-emu/shadPS4/commit/e5486cc57f9dfa6cf46803c776561361ec511186) video_core: amdgpu: proper destruction of processing thread - [`db113bb`](https://github.com/shadps4-emu/shadPS4/commit/db113bbc7b3a05d836943d42d44b2d81f9cc7661) videoout, platform: fix for ooo irqs - [`5f37a6b`](https://github.com/shadps4-emu/shadPS4/commit/5f37a6be83c7dd38cc2dc1513c05cdf1c2f951af) video_core: amdgpu: fix for a deadlock in wait on idle - [`a67b8f7`](https://github.com/shadps4-emu/shadPS4/commit/a67b8f7a0b9204f78c7e4071e92a18c4b5fbe59e) video_core: renderer_vulkan: proper inclusion of maintenance4 - [`055dec1`](https://github.com/shadps4-emu/shadPS4/commit/055dec11499f7f8e7d607642225a8daa5dbbd04e) video_core: texture_cache: proper `UniqueImage` class movers - [`7fc273c`](https://github.com/shadps4-emu/shadPS4/commit/7fc273c6bc6817696364421cc1f88965e36e99a4) clang fmt ### 📊 Changes **9 files changed** (+31 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/core/libraries/libc/libc_math.cpp` (+8 -2) 📝 `src/core/libraries/libc/libc_math.h` (+1 -1) 📝 `src/core/libraries/videoout/driver.h` (+1 -1) 📝 `src/core/libraries/videoout/video_out.cpp` (+1 -0) 📝 `src/core/platform.h` (+1 -1) 📝 `src/video_core/amdgpu/liverpool.cpp` (+12 -18) 📝 `src/video_core/amdgpu/liverpool.h` (+0 -3) 📝 `src/video_core/renderer_vulkan/vk_instance.cpp` (+1 -3) 📝 `src/video_core/texture_cache/image.h` (+6 -1) </details> ### 📄 Description This PR addresses the next issues: - out of order flip IRQ processing; - incorrect renderer de-initialization; - possible deadlock in gpu idle waits; - incorrect `_Fsin` implementation in HLE libc --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>