mirror of
https://github.com/s3fs-fuse/s3fs-fuse.git
synced 2026-04-25 21:35:58 +03:00
[GH-ISSUE #1872] S3fs Mounted folder show invalidate timestamp as "1969-12-31 23:59:59" #954
Labels
No labels
bug
bug
dataloss
duplicate
enhancement
feature request
help wanted
invalid
need info
performance
pull-request
question
question
testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/s3fs-fuse#954
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @tomato0401 on GitHub (Jan 25, 2022).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/1872
s3fs version: v1.90
s3 backend: minio-RELEASE.2019-10-12T01-39-57Z
I use a minio instance for s3 storage, when i mount it to local use s3fs command, some folder shows invalid timestamp. That cause my python code could not import libs from those folders.
I found that in this file "https://github.com/s3fs-fuse/s3fs-fuse/blob/v1.90/src/metaheader.cpp" get_time get_ctime get_mtime return -1 while "x-amz-meta-xxxx" is not provided.
Why should these method return -1 but not 0, some where -1 is consided as wrong time and cause many unnormal action.
@gaul commented on GitHub (Jan 25, 2022):
This seems like an issue where -1 should indicate the absence of a timestamp on the object but should reflect as 0 to the application. This should be an easy fix to
s3fs_getattr; would you like to try fixing this? Also add a test totest_read_external_objectfor the metadata.@ggtakec commented on GitHub (Jan 29, 2022):
There was a problem with the processing(this issue), and I posted new PR(#1877) to fix this.
Note:
These functions return
-1, which reason is used in the internal processing to determine whether or not the object does not have a headers(x-meta-***).In that PR fix, it set
0when getting-1in function which does not require judgment.If the PR is merged without any problem, I would be grateful if you could confirm it.
@gaul commented on GitHub (Sep 8, 2023):
Closing as fixed. Please reopen if you can reproduce these symptoms with 1.93.