[PR #1233] [MERGED] break recursion when calling GetIAMCredentials #1877

New issue

Closed

opened 2026-03-04 02:02:36 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 02:02:36 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/s3fs-fuse/s3fs-fuse/pull/1233
Author: @rallister
Created: 1/29/2020
Status: ✅ Merged
Merged: 1/31/2020
Merged by: @ggtakec

Base: master ← Head: master

📝 Commits (9)

61ae994 Update curl.cpp
c1eaef5 Update curl.h
b773580 Update curl.cpp
8b93328 Update curl.cpp
7316f07 added braces
019b677 Revert "added braces"
0c8f371 add braces
51536ac Dont insert auth headers when calling IAM meta-data endpoint.
f153e54 Merge branch 'master' of github.com:rallister/s3fs-fuse

📊 Changes

2 files changed (+8 additions, -5 deletions)

View changed files

📝 src/curl.cpp (+7 -4)
📝 src/curl.h (+1 -1)

📄 Description

Relevant Issue (if applicable)

https://github.com/s3fs-fuse/s3fs-fuse/issues/1196

Details

Added a flag to not insert authHeaders when calling GetIAMCredentials, because they are not needed in this call but also to break recursion which occurs in issue 1196
CheckIAMCredentialUpdate() ->
GetIAMCredentials() ->
RequestPerform() ->
insertAuthHeaders() ----> back to CheckIAMCredentialUpdate()

You might come up with a better way but this quickly got me out of a bind.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/s3fs-fuse/s3fs-fuse/pull/1233 **Author:** [@rallister](https://github.com/rallister) **Created:** 1/29/2020 **Status:** ✅ Merged **Merged:** 1/31/2020 **Merged by:** [@ggtakec](https://github.com/ggtakec) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (9) - [`61ae994`](https://github.com/s3fs-fuse/s3fs-fuse/commit/61ae994419f08894e0fecf01d018998dc7e0648b) Update curl.cpp - [`c1eaef5`](https://github.com/s3fs-fuse/s3fs-fuse/commit/c1eaef5f7a71fbe3bd6cdc40d97925503b265a40) Update curl.h - [`b773580`](https://github.com/s3fs-fuse/s3fs-fuse/commit/b773580256da0ad876ce8f1e813304efbc08dd00) Update curl.cpp - [`8b93328`](https://github.com/s3fs-fuse/s3fs-fuse/commit/8b933287a5fdce495669ee450915c416ae381649) Update curl.cpp - [`7316f07`](https://github.com/s3fs-fuse/s3fs-fuse/commit/7316f077a428e7e4670826f387d56dcad86ffd3a) added braces - [`019b677`](https://github.com/s3fs-fuse/s3fs-fuse/commit/019b677b26ffbb2ab0478e41221fb9a32360e886) Revert "added braces" - [`0c8f371`](https://github.com/s3fs-fuse/s3fs-fuse/commit/0c8f371ef3eff349b311515147acd1ebdd7cebde) add braces - [`51536ac`](https://github.com/s3fs-fuse/s3fs-fuse/commit/51536ace97e5469e5891313d406377a0e5b5969e) Dont insert auth headers when calling IAM meta-data endpoint. - [`f153e54`](https://github.com/s3fs-fuse/s3fs-fuse/commit/f153e54502f441a6b216cf14b9a933dec0434caa) Merge branch 'master' of github.com:rallister/s3fs-fuse ### 📊 Changes **2 files changed** (+8 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/curl.cpp` (+7 -4) 📝 `src/curl.h` (+1 -1) </details> ### 📄 Description ### Relevant Issue (if applicable) https://github.com/s3fs-fuse/s3fs-fuse/issues/1196 ### Details Added a flag to not insert authHeaders when calling GetIAMCredentials, because they are not needed in this call but also to break recursion which occurs in issue 1196 CheckIAMCredentialUpdate() -> GetIAMCredentials() -> RequestPerform() -> insertAuthHeaders() ----> back to CheckIAMCredentialUpdate() You might come up with a better way but this quickly got me out of a bind. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>