[GH-ISSUE #927] Consider changing `-o notsup_compat_dir` default #527

New issue

Closed

opened 2026-03-04 01:46:23 +03:00 by kerem · 2 comments

kerem commented

2026-03-04 01:46:23 +03:00

Owner

Originally created by @gaul on GitHub (Jan 24, 2019).
Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/927

#571 added an optimization to disable the legacy dirname_$folder$ checking. Should s3fs default to the optimization on since most installations should use the dirname/ format and have an option to check for the legacy folders instead?

Originally created by @gaul on GitHub (Jan 24, 2019). Original GitHub issue: https://github.com/s3fs-fuse/s3fs-fuse/issues/927 #571 added an optimization to disable the legacy `dirname_$folder$` checking. Should s3fs default to the optimization on since most installations should use the `dirname/` format and have an option to check for the legacy folders instead?

kerem

2026-03-04 01:46:23 +03:00

closed this issue
added the
performance
label

kerem commented

2026-03-04 01:46:24 +03:00

Author

Owner

@ggtakec commented on GitHub (Mar 29, 2019):

@gaul
Currently, I agree that I no longer need to search for the _$folder$ object.

In addition to this, s3fs supports the no directory object case.
This is when there is no intermediate path dir or dir/ and there is only a dir/path object.
I think we need to continue to support this pattern.

With the fix of #571 , support_compat_dir flag is defined in s3fs.cpp. However, this flag is also used to check the no directory object above.
So we need to think about the correspondence of the no directory object case with this issue as well.

I think we let s3fs not check the _$folder$ object by default, but a case of no directory object should continue checking.

Please let me know your opinion about it.

@ggtakec commented on GitHub (Mar 29, 2019): @gaul Currently, I agree that I no longer need to search for the `_$folder$` object. In addition to this, s3fs supports the `no directory object` case. This is when there is no intermediate path `dir` or `dir/` and there is only a `dir/path` object. I think we need to continue to support this pattern. With the fix of #571 , `support_compat_dir flag` is defined in s3fs.cpp. However, this flag is also used to check the `no directory object` above. So we need to think about the correspondence of the `no directory object` case with this issue as well. I think we let s3fs not check the `_$folder$` object by default, but a case of `no directory object` should continue checking. Please let me know your opinion about it.

kerem commented

2026-03-04 01:46:24 +03:00

Author

Owner

@gaul commented on GitHub (Feb 8, 2021):

We should also add a script to detect and convert buckets which use the older compat dirs.

@gaul commented on GitHub (Feb 8, 2021): We should also add a script to detect and convert buckets which use the older compat dirs.